Uh oh!
There was an error while loading. Please reload this page.
gh-119189: Add more tests for mixed Fraction arithmetic - #119236
gh-119189: Add more tests for mixed Fraction arithmetic#119236serhiy-storchaka merged 2 commits into
Conversation
mdickinson
left a comment
There was a problem hiding this comment.
LGTM; two nitpick-level comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
dc34aa1 to
c1f6081CompareThanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…GH-119236) (cherry picked from commit fe67af1) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…GH-119236) (cherry picked from commit fe67af1) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-119255 is a backport of this pull request to the 3.13 branch. |
GH-119256 is a backport of this pull request to the 3.12 branch. |
scoder
commented
Nov 28, 2024
I noticed that the newly added tests are written the wrong way around. When a test fails, it says something like Note how versus |
serhiy-storchaka
commented
Dec 3, 2024
The normal order for assertEqual() is actual, expected. But some old tests are written with other order. We do not touch them to avoid code churn. It seems that old tests here were written in such order, but assertTy po edEquals then reverted the order . |
Uh oh!
There was an error while loading. Please reload this page.