Skip to content

gh-111201: Remove readline dependency from the PyREPL - #119262

Merged
ambv merged 3 commits into
python:mainfrom
lysnikolaou:pyrepl-remove-readline
May 21, 2024
Merged

gh-111201: Remove readline dependency from the PyREPL#119262
ambv merged 3 commits into
python:mainfrom
lysnikolaou:pyrepl-remove-readline

Conversation

@lysnikolaou

@lysnikolaoulysnikolaou commented May 20, 2024

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request May 20, 2024
7 tasks
@lysnikolaou
lysnikolaou requested review from ambv and pablogsalMay 20, 2024 20:29
@lysnikolaoulysnikolaou added the topic-repl Related to the interactive shell label May 20, 2024
@ambv
ambv enabled auto-merge (squash) May 21, 2024 18:53
@ambv
ambv disabled auto-merge May 21, 2024 20:19
@ambv
ambv merged commit 561ff1f into python:mainMay 21, 2024
@lysnikolaoulysnikolaou added the needs backport to 3.13 bugs and security fixes label May 21, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @lysnikolaou for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @lysnikolaou and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 561ff1fa710493dee8c6482f990bd17535b27040 3.13

lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull request May 22, 2024
…ythonGH-119262)
(cherry picked from commit 561ff1f)
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@bedevere-app

Copy link
Copy Markdown

GH-119403 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 22, 2024
lysnikolaou added a commit that referenced this pull request May 22, 2024
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.13 has failed when building commit ac91636.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1386/builds/72) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac91636) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1386/builds/72

Failed tests:

  • test_socketserver

Failed subtests:

  • test_UnixDatagramServer - test.test_socketserver.SocketServerTest.test_UnixDatagramServer

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
File "/Users/buildbot/Library/Developer/XCTestDevices/9C960735-F7A1-480F-9787-7AD43982830A/data/Containers/Bundle/Application/7D8D4A2B-9A9A-473C-AECA-3DB701263F70/iOSTestbed.app/python/lib/python3.13/test/test_socketserver.py", line 222, in test_UnixDatagramServerself.run_server(socketserver.UnixDatagramServer,
~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
socketserver.DatagramRequestHandler,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^self.dgram_examine)
^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9C960735-F7A1-480F-9787-7AD43982830A/data/Containers/Bundle/Application/7D8D4A2B-9A9A-473C-AECA-3DB701263F70/iOSTestbed.app/python/lib/python3.13/test/support/threading_helper.py", line 66, in decoratorreturn func(*args)
File "/Users/buildbot/Library/Developer/XCTestDevices/9C960735-F7A1-480F-9787-7AD43982830A/data/Containers/Bundle/Application/7D8D4A2B-9A9A-473C-AECA-3DB701263F70/iOSTestbed.app/python/lib/python3.13/test/test_socketserver.py", line 133, in run_server
testfunc(svrcls.address_family, addr)
~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9C960735-F7A1-480F-9787-7AD43982830A/data/Containers/Bundle/Application/7D8D4A2B-9A9A-473C-AECA-3DB701263F70/iOSTestbed.app/python/lib/python3.13/test/test_socketserver.py", line 160, in dgram_examine
buf = data = receive(s, 100)
~~~~~~~^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9C960735-F7A1-480F-9787-7AD43982830A/data/Containers/Bundle/Application/7D8D4A2B-9A9A-473C-AECA-3DB701263F70/iOSTestbed.app/python/lib/python3.13/test/test_socketserver.py", line 43, in receiveraiseRuntimeError("timed out on %r"% (sock,))
RuntimeError: timed out on <socket.socket fd=33, family=1, type=2, proto=0, laddr=./test_python_5zh11swb.sock>
Traceback (most recent call last):
File "/Users/buildbot/Library/Developer/XCTestDevices/9C960735-F7A1-480F-9787-7AD43982830A/data/Containers/Bundle/Application/7D8D4A2B-9A9A-473C-AECA-3DB701263F70/iOSTestbed.app/python/lib/python3.13/threading.py", line 1039, in _bootstrap_innerself.run()
~~~~~~~~^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9C960735-F7A1-480F-9787-7AD43982830A/data/Containers/Bundle/Application/7D8D4A2B-9A9A-473C-AECA-3DB701263F70/iOSTestbed.app/python/lib/python3.13/threading.py", line 990, in runself._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9C960735-F7A1-480F-9787-7AD43982830A/data/Containers/Bundle/Application/7D8D4A2B-9A9A-473C-AECA-3DB701263F70/iOSTestbed.app/python/lib/python3.13/socketserver.py", line 240, in serve_foreverself._handle_request_noblock()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9C960735-F7A1-480F-9787-7AD43982830A/data/Containers/Bundle/Application/7D8D4A2B-9A9A-473C-AECA-3DB701263F70/iOSTestbed.app/python/lib/python3.13/socketserver.py", line 320, in _handle_request_noblockself.handle_error(request, client_address)
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9C960735-F7A1-480F-9787-7AD43982830A/data/Containers/Bundle/Application/7D8D4A2B-9A9A-473C-AECA-3DB701263F70/iOSTestbed.app/python/lib/python3.13/socketserver.py", line 318, in _handle_request_noblockself.process_request(request, client_address)
~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9C960735-F7A1-480F-9787-7AD43982830A/data/Containers/Bundle/Application/7D8D4A2B-9A9A-473C-AECA-3DB701263F70/iOSTestbed.app/python/lib/python3.13/socketserver.py", line 349, in process_requestself.finish_request(request, client_address)
~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9C960735-F7A1-480F-9787-7AD43982830A/data/Containers/Bundle/Application/7D8D4A2B-9A9A-473C-AECA-3DB701263F70/iOSTestbed.app/python/lib/python3.13/socketserver.py", line 362, in finish_requestself.RequestHandlerClass(request, client_address, self)
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9C960735-F7A1-480F-9787-7AD43982830A/data/Containers/Bundle/Application/7D8D4A2B-9A9A-473C-AECA-3DB701263F70/iOSTestbed.app/python/lib/python3.13/socketserver.py", line 763, in __init__self.finish()
~~~~~~~~~~~^^
File "/Users/buildbot/Library/Developer/XCTestDevices/9C960735-F7A1-480F-9787-7AD43982830A/data/Containers/Bundle/Application/7D8D4A2B-9A9A-473C-AECA-3DB701263F70/iOSTestbed.app/python/lib/python3.13/socketserver.py", line 858, in finishself.socket.sendto(self.wfile.getvalue(), self.client_address)
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ConnectionResetError: [Errno 54] Connection reset by peer
ERROR

@lysnikolaou

Copy link
Copy Markdown
MemberAuthor

Buildbot failure appears to be unrelated.

@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic-replRelated to the interactive shell

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lysnikolaou@bedevere-bot@ambv