Uh oh!
There was an error while loading. Please reload this page.
gh-117657: Fix missing atomic in dict_resize - #119312
Merged
Merged
Conversation
DinoV
requested review from
colesbury
and removed request for
markshannon and methaneMay 21, 2024 14:44
colesbury
approved these changes
May 21, 2024
colesbury
left a comment
Contributor
There was a problem hiding this comment.
We should backport this to 3.13
DinoV
commented
May 22, 2024
ContributorAuthor
Backport to 3.13: #119416 |
Thanks @DinoV for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 22, 2024
Fix missing atomic in dict_resize (cherry picked from commit 2b3fb76) Co-authored-by: Dino Viehland <dinoviehland@meta.com>
GH-119417 is a backport of this pull request to the 3.13 branch. |
DinoV added a commit
that referenced
this pull request
May 22, 2024
estyxx pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Fix missing atomic in dict_resize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use atomic to assign to PyDictValues->valid like we do elsewhere