Skip to content

gh-118893: Evaluate all statements in the new REPL separately - #119318

Merged
ambv merged 3 commits into
python:mainfrom
pablogsal:stmts-fix-2
May 21, 2024
Merged

gh-118893: Evaluate all statements in the new REPL separately#119318
ambv merged 3 commits into
python:mainfrom
pablogsal:stmts-fix-2

Conversation

@pablogsal

@pablogsalpablogsal commented May 21, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request May 21, 2024
Closed
@pablogsal
pablogsal requested a review from ambvMay 21, 2024 16:06
@pablogsal
pablogsalforce-pushed the stmts-fix-2 branch 2 times, most recently from fcc44e6 to 40df02eCompareMay 21, 2024 16:25
@ambvambv added the topic-repl Related to the interactive shell label May 21, 2024
@pablogsalpablogsal mentioned this pull request May 21, 2024
Merged
@ambv
ambv enabled auto-merge (squash) May 21, 2024 19:12
lysnikolaou
lysnikolaou approved these changes May 21, 2024
View reviewed changes

@lysnikolaoulysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge this!

@ambv
ambv merged commit a3e4fec into python:mainMay 21, 2024
@lysnikolaoulysnikolaou added the needs backport to 3.13 bugs and security fixes label May 22, 2024
@miss-islington-app

miss-islington-appBot commented May 22, 2024

Copy link
Copy Markdown

Thanks @pablogsal for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
@pablogsal@ambv@miss-islington
pythongh-118893: Evaluate all statements in the new REPL separately (p…
76b149e
…ythonGH-119318)
(cherry picked from commit a3e4fec)
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app

bedevere-appBot commented May 22, 2024

Copy link
Copy Markdown

GH-119408 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 22, 2024
lysnikolaou pushed a commit that referenced this pull request May 22, 2024
@miss-islington@pablogsal@ambv
[3.13]gh-118893: Evaluate all statements in the new REPL separately (G…
a463cd8
…H-119318) (#119408)
(cherry picked from commit a3e4fec)
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@pablogsal@ambv@estyxx
pythongh-118893: Evaluate all statements in the new REPL separately (p…
83f9099
…ython#119318)
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@skirpichevskirpichev mentioned this pull request Jul 17, 2024
Merged
@serhiy-storchakaserhiy-storchaka mentioned this pull request Aug 16, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaoulysnikolaoulysnikolaou approved these changes
@ambvambvAwaiting requested review from ambvambv is a code owner
@iritkatrieliritkatrielAwaiting requested review from iritkatriel

Assignees

No one assigned

Labels

skip newstopic-replRelated to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pablogsal@lysnikolaou@ambv