Uh oh!
There was an error while loading. Please reload this page.
DOCS: fix error in exec namespace note - #119378
Merged
ncoghlan merged 2 commits intoMay 22, 2024
Merged
Conversation
When updating the new exec note added in pythongh-119235 as part of the PEP 667 general docs PR, I suggested a workaround that isn't valid. Since it's far from the first time I've considered that workaround, and the fact it doesn't work has surprised me every time, amend the new note to explicitly state that dict merging is the only option.
ncoghlan
commented
May 22, 2024
ContributorAuthor
Only backporting to 3.13, since the incorrect workaround was never added to the 3.12 note. |
This was referenced May 22, 2024
gvanrossum
left a comment
Member
There was a problem hiding this comment.
I would
Just delete the incorrect workaround. It doesn’t seem very valuable to explicitly document something that doesn’t work, nor the cumbersome copying.
ncoghlan
commented
May 22, 2024
ContributorAuthor
Good point, done (and set to merge once CI is happy). |
ncoghlan
enabled auto-merge (squash)
May 22, 2024 06:23
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 22, 2024
When updating the new exec note added in pythongh-119235 as part of the PEP 667 general docs PR, I suggested a workaround that isn't valid. The first half of the note is still reasonable, so just omit the invalid text. (cherry picked from commit 31d61a7) Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>
GH-119380 is a backport of this pull request to the 3.13 branch. |
estyxx pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
When updating the new exec note added in pythongh-119235 as part of the PEP 667 general docs PR, I suggested a workaround that isn't valid. The first half of the note is still reasonable, so just omit the invalid text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating the new exec note added in gh-119235 as part of the PEP 667 general docs PR, I suggested a workaround that isn't valid.
Since it's far from the first time I've considered that workaround, and the fact it doesn't work has surprised me every time, amend the new note to explicitly state that dict merging is the only option.
📚 Documentation preview 📚: https://cpython-previews--119378.org.readthedocs.build/