Uh oh!
There was an error while loading. Please reload this page.
[3.12] gh-118507 : Fix ntpath.isfile for pipes. - #119381
Merged
Merged
Conversation
This was referenced May 22, 2024
ContributorAuthor
I think I didn't include unrelated changes. Is it fine to use the C version for |
nineteendo
marked this pull request as ready for review
May 22, 2024 07:23
nt._path_is* (GH-118755)nt._path_is* to improve applicability for other cases (GH-118755)zooba
commented
May 22, 2024
Member
Let's revert those, just to minimise the risk of changed behaviour. We can consider backporting them later once we're more confident. |
ContributorAuthor
Done, I also removed the C implementation for these functions to not give anyone ideas... |
nt._path_is* to improve applicability for other cases (GH-118755)ntpath.isfile for pipes.zooba
commented
May 22, 2024
Member
A draft pull request is a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nt._path_is*&nt._path_[l]exists#118507