gh-119727: Add --single-process option to regrtest by vstinner · Pull Request #119728 · python/cpython

vstinner · 2024-05-29T13:29:07Z

Issue: Add --single-process option to regrtest to always run tests sequentially (ignore -jN option) #119727

vstinner · 2024-05-29T13:29:43Z

serhiy-storchaka

Alternative names are --singleprocess and --no-multiprocess, which more accurately describe the effect, but this is up to you.

I think that the implementation can be simplified by reusing the same destination variable. It is more common in such cases.

serhiy-storchaka · 2024-05-30T10:18:25Z

 group.add_argument('-j', '--multiprocess', metavar='PROCESSES',
 dest='use_mp', type=int,
 help='run PROCESSES processes at once')
+ group.add_argument('--sequentially', action='store_true',


You can also implement it as action='store_const', dest='use_mp', const=None.

serhiy-storchaka · 2024-05-30T10:20:17Z

-NEED_TTY = set('''
- test_ioctl
-'''.split())
+NEED_TTY = {


Not related.

Yeah, it's a follow-up of a previous PR. I didn't want to write a dedicated PR for that.

vstinner · 2024-05-31T11:11:57Z

@Yhg1s @hugovk: Since the release process requires to run tests sequentially, do you have a preference for the option name?

--singleprocess (close to the existing --single option)
--no-multiprocess
--sequentially
--sameprocess
something else?

hugovk · 2024-05-31T12:29:34Z

My first thought is to use something like -j 1 rather than adding a new option. Would this work?

 -j, --multiprocess PROCESSES
run PROCESSES processes at once

This is similar to pytest-xdist (-n or --numprocesses) and sphinx-build (-j or --jobs).

vstinner · 2024-05-31T12:39:56Z

My first thought is to use something like -j 1 rather than adding a new option. Would this work?

Currently, -j1 runs tests sequentially but spawn a new process for each test file: see #119727 (comment). I'm open to consider changing this behavior.

hugovk · 2024-05-31T12:55:09Z

Do you think anyone will realistically want to run sequentially and spawn a new process for each? My guess is not.

vstinner · 2024-06-03T15:48:46Z

I'm a little bit worried that some projects currently run tests with -j1 with good reasons, and changing that can lead to surprising results. I would prefer to add a new option.

According to the discussion, the least bad choice is --singleprocess option name :-)

hugovk · 2024-06-03T15:55:27Z

Then I'd include a hyphen for readability/accessibility: --single-process

We have a mixture of options with and without hyphens, so consistency isn't a problem :)

vstinner · 2024-06-03T15:59:51Z

I updated the PR to use --single-process name. Are you ok with that @serhiy-storchaka and @hugovk?

serhiy-storchaka · 2024-06-03T16:00:21Z

It does not really matter. It was just a tiny nitpick from my side. Use the name that you like if you are sure that it will not create problems in future.

…aZM.rst Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

miss-islington-app · 2024-08-14T12:30:16Z

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app · 2024-08-14T12:30:19Z

Sorry, @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4e8aa32245e2d72bf558b711ccdbcee594347615 3.13

mhsmith · 2024-08-14T12:32:47Z

I'll submit a backport of this because it would be useful for the iOS and Android buildbots – #122992 (comment).

(cherry picked from commit 4e8aa32)

bedevere-app · 2024-08-14T13:28:50Z

GH-123010 is a backport of this pull request to the 3.13 branch.

miss-islington-app · 2024-08-26T09:14:36Z

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app · 2024-08-26T09:14:38Z

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4e8aa32245e2d72bf558b711ccdbcee594347615 3.12

…123010) gh-119727: Add --single-process option to regrtest (#119728) (cherry picked from commit 4e8aa32) Co-authored-by: Victor Stinner <vstinner@python.org>

…onGH-119728) (cherry picked from commit 4e8aa32) Co-authored-by: Victor Stinner <vstinner@python.org>

bedevere-app · 2025-02-20T15:31:11Z

GH-130359 is a backport of this pull request to the 3.12 branch.

…#130359) Co-authored-by: Victor Stinner <vstinner@python.org>

pythongh-119727: Add --sequentially option to regrtest
ef0522a

bedevere-appBot added the awaiting core review label May 29, 2024

bedevere-appBot mentioned this pull request May 29, 2024
Add --single-process option to regrtest to always run tests sequentially (ignore -jN option) #119727
Closed

Change NEED_TTY formatting
46a1e77

vstinner mentioned this pull request May 29, 2024
gh-119273: Don't run test_ioctl in a process group #119275
Merged

serhiy-storchaka approved these changes May 30, 2024
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting core review labels May 30, 2024

Rename the option to: --single-process
4d50b87

hugovk approved these changes Jun 3, 2024
View reviewed changes

Comment threadMisc/NEWS.d/next/Tests/2024-05-29-15-28-08.gh-issue-119727.dVkaZM.rst Outdated

Update Misc/NEWS.d/next/Tests/2024-05-29-15-28-08.gh-issue-119727.dVk…
90fb9fe
…aZM.rst Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

vstinner enabled auto-merge (squash) June 3, 2024 16:11

vstinner merged commit 4e8aa32 into python:mainJun 3, 2024

vstinner deleted the regrtest_seq branch June 3, 2024 16:34

bedevere-appBot removed the awaiting merge label Jun 3, 2024

hugovk changed the title ~~gh-119727: Add --sequentially option to regrtest~~gh-119727: Add --single-process option to regrtestJun 3, 2024

mliezun pushed a commit to mliezun/cpython that referenced this pull request Jun 3, 2024
pythongh-119727: Add --single-process option to regrtest (python#119728)
035ef28

barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
pythongh-119727: Add --single-process option to regrtest (python#119728)
713d900

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
pythongh-119727: Add --single-process option to regrtest (python#119728)
dea4632

estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-119727: Add --single-process option to regrtest (python#119728)
7dd93f0

freakboy3742 mentioned this pull request Aug 14, 2024
Add a --rerun option to the iOS testbed. #122992
Merged

freakboy3742 mentioned this pull request Aug 14, 2024
[3.13] Revert use of --rerun in iOS testbed. #122995
Merged

mhsmith added the needs backport to 3.13 bugs and security fixes label Aug 14, 2024

miss-islington-appBot assigned vstinner Aug 14, 2024

mhsmith assigned mhsmith and unassigned vstinner Aug 14, 2024

mhsmith pushed a commit to mhsmith/cpython that referenced this pull request Aug 14, 2024
pythongh-119727: Add --single-process option to regrtest (python#119728)
4185f2b
(cherry picked from commit 4e8aa32)

bedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Aug 14, 2024

vstinner added the needs backport to 3.12 only security fixes label Aug 26, 2024

miss-islington-appBot assigned vstinner and unassigned mhsmith Aug 26, 2024

hugovk pushed a commit to hugovk/cpython that referenced this pull request Feb 20, 2025
[3.12]pythongh-119727: Add --single-process option to regrtest (pyth…
ccb4ead
…onGH-119728) (cherry picked from commit 4e8aa32) Co-authored-by: Victor Stinner <vstinner@python.org>

bedevere-appBot removed the needs backport to 3.12 only security fixes label Feb 20, 2025

hugovk added a commit that referenced this pull request Feb 20, 2025
[3.12]gh-119727: Add --single-process option to regrtest (GH-119728) (…
ecfca20
…#130359) Co-authored-by: Victor Stinner <vstinner@python.org>

Uh oh!

Uh oh!

Conversation

vstinner commented May 29, 2024• edited by bedevere-app BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented May 29, 2024

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchakaMay 30, 2024

Choose a reason for hiding this comment

Uh oh!

serhiy-storchakaMay 30, 2024

Choose a reason for hiding this comment

Uh oh!

vstinnerJun 3, 2024

Choose a reason for hiding this comment

Uh oh!

vstinner commented May 31, 2024

Uh oh!

hugovk commented May 31, 2024

Uh oh!

vstinner commented May 31, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hugovk commented May 31, 2024

Uh oh!

vstinner commented Jun 3, 2024

Uh oh!

hugovk commented Jun 3, 2024

Uh oh!

vstinner commented Jun 3, 2024

Uh oh!

serhiy-storchaka commented Jun 3, 2024

Uh oh!

Uh oh!

miss-islington-appBot commented Aug 14, 2024

Uh oh!

miss-islington-appBot commented Aug 14, 2024

Uh oh!

mhsmith commented Aug 14, 2024

Uh oh!

bedevere-appBot commented Aug 14, 2024

Uh oh!

miss-islington-appBot commented Aug 26, 2024

Uh oh!

miss-islington-appBot commented Aug 26, 2024

Uh oh!

bedevere-appBot commented Feb 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vstinner commented May 29, 2024•
edited by bedevere-app Bot
Loading

vstinner commented May 31, 2024•
edited
Loading