Skip to content

gh-119740: Remove deprecated trunc delegation - #119743

Merged
mdickinson merged 18 commits into
python:mainfrom
mdickinson:remove-deprecated-trunc-delegation
Jun 2, 2024
Merged

gh-119740: Remove deprecated trunc delegation#119743
mdickinson merged 18 commits into
python:mainfrom
mdickinson:remove-deprecated-trunc-delegation

Conversation

@mdickinson

@mdickinsonmdickinson commented May 29, 2024•
edited
Loading

Copy link
Copy Markdown
Member

This PR removes the delegation of int to the __trunc__ special method: int will now only delegate to __int__ and __index__ (in that order). __trunc__ continues to exist, but its sole purpose is to support math.trunc.

📚 Documentation preview 📚: https://cpython-previews--119743.org.readthedocs.build/

@bedevere-appbedevere-appBot mentioned this pull request May 29, 2024
Closed
serhiy-storchaka
serhiy-storchaka reviewed May 29, 2024
View reviewed changes
Comment threadDoc/library/functions.rst Outdated
Comment threadDoc/reference/datamodel.rst Outdated
Comment threadDoc/library/functions.rst Outdated
Comment threadDoc/whatsnew/3.14.rst Outdated
serhiy-storchaka
serhiy-storchaka approved these changes May 30, 2024
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would prefer to merge this after #119687, to make backporting of #119687 easier.

Comment threadDoc/whatsnew/3.14.rst Outdated
Comment threadDoc/library/functions.rst Outdated
picnixz
picnixz reviewed May 30, 2024
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
Comment threadDoc/library/functions.rst Outdated
@mdickinson

mdickinson commented May 31, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks for the comments; I'll address before merging (but it may take me a few days to get to it).

@mdickinson

mdickinson commented May 31, 2024

Copy link
Copy Markdown
MemberAuthor

But I would prefer to merge this after #119687, to make backporting of #119687 easier.

Definitely! Looks like #119687 has gone in now; I'll update for conflicts when I get the chance.

mdickinsonand others added 2 commits June 2, 2024 09:34
@mdickinson@picnixz
More direct wording
1c2a638
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@mdickinson@picnixz
Grammar nit
26d5833
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
mdickinson
mdickinson commented Jun 2, 2024
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
mdickinsonand others added 2 commits June 2, 2024 09:37
mdickinson
mdickinson commented Jun 2, 2024
View reviewed changes
Comment threadDoc/reference/datamodel.rst Outdated
@mdickinson

mdickinson commented Jun 2, 2024

Copy link
Copy Markdown
MemberAuthor

Updating for merge conflicts ...

@mdickinson
mdickinson merged commit f79ffc8 into python:mainJun 2, 2024
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@mdickinson@picnixz
@serhiy-storchaka@barneygale
pythongh-119740: Remove deprecated trunc delegation (python#119743)
c0c837a
Remove the delegation of `int` to the `__trunc__` special method: `int` will now only delegate to `__int__` and `__index__` (in that order). `__trunc__` continues to exist, but its sole purpose is to support `math.trunc`.
---------
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@mdickinson@picnixz
@serhiy-storchaka@noahbkim
pythongh-119740: Remove deprecated trunc delegation (python#119743)
327e81d
Remove the delegation of `int` to the `__trunc__` special method: `int` will now only delegate to `__int__` and `__index__` (in that order). `__trunc__` continues to exist, but its sole purpose is to support `math.trunc`.
---------
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@mdickinson@picnixz
@serhiy-storchaka@estyxx
pythongh-119740: Remove deprecated trunc delegation (python#119743)
8bb4fb3
Remove the delegation of `int` to the `__trunc__` special method: `int` will now only delegate to `__int__` and `__index__` (in that order). `__trunc__` continues to exist, but its sole purpose is to support `math.trunc`.
---------
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
skirpichev added a commit to skirpichev/cpython that referenced this pull request Feb 9, 2026
@skirpichev
pythongh-119743: remove obsoleted removal announce for trunc delegation
345ac2a
This was done in python#119743 (3.14).
@skirpichevskirpichev mentioned this pull request Feb 9, 2026
Merged
serhiy-storchaka pushed a commit that referenced this pull request Feb 9, 2026
@skirpichev
gh-119740: Remove obsoleted removal announce for trunc delegation (GH…
aa6ed80
…-144622)
This was done in GH-119743 (3.14).
@miss-islingtonmiss-islington mentioned this pull request Feb 9, 2026
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 9, 2026
@skirpichev@miss-islington
pythongh-119740: Remove obsoleted removal announce for trunc delegati…
288cdb8
…on (pythonGH-144622)
This was done in pythonGH-119743 (3.14).
(cherry picked from commit aa6ed80)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Feb 9, 2026
@miss-islington@skirpichev
[3.14]gh-119740: Remove obsoleted removal announce for trunc delegat…
c9646df
…ion (GH-144622) (GH-144624)
This was done in GH-119743 (3.14).
(cherry picked from commit aa6ed80)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@skirpichev@thunder-coding
pythongh-119740: Remove obsoleted removal announce for trunc delegati…
8dab2c0
…on (pythonGH-144622)
This was done in pythonGH-119743 (3.14).
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@skirpichev@ljfp
pythongh-119740: Remove obsoleted removal announce for trunc delegati…
3a9df08
…on (pythonGH-144622)
This was done in pythonGH-119743 (3.14).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments
@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdickinson@serhiy-storchaka@picnixz