Skip to content

bpo-36073: Raise ProgrammingError on recursive usage of cursors in sqlite converters - #11984

Closed
sir-sigurd wants to merge 1 commit into
python:mainfrom
sir-sigurd:sqlite-converter-segfault
Closed

bpo-36073: Raise ProgrammingError on recursive usage of cursors in sqlite converters#11984
sir-sigurd wants to merge 1 commit into
python:mainfrom
sir-sigurd:sqlite-converter-segfault

Conversation

@sir-sigurd

@sir-sigurdsir-sigurd commented Feb 22, 2019•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@sir-sigurd
sir-sigurdforce-pushed the sqlite-converter-segfault branch from 6a8c1fb to f1a838aCompareFebruary 22, 2019 07:50
BoboTiG
BoboTiG reviewed Jun 21, 2019
View reviewed changes
Comment threadLib/sqlite3/test/regression.py Outdated
@BoboTiG

BoboTiG commented Jun 21, 2019

Copy link
Copy Markdown
Contributor

Thanks @sir-sigurd, I think a NEWs entry would be interesting, don't you?

@sir-sigurd
sir-sigurdforce-pushed the sqlite-converter-segfault branch 2 times, most recently from 16a6d90 to 6f1b983CompareJune 22, 2019 10:27
@erlend-aasland

erlend-aasland commented Apr 1, 2021

Copy link
Copy Markdown
Contributor

@sir-sigurd, can you rebase onto master?

erlend-aasland
erlend-aasland requested changes Apr 8, 2021
View reviewed changes
Comment threadModules/_sqlite/cursor.c Outdated
Comment on lines 365 to 366

@erlend-aaslanderlend-aaslandApr 8, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format these lines according to PEP 7.

Comment threadModules/_sqlite/cursor.c Outdated

@erlend-aaslanderlend-aaslandApr 8, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is longer than 79 characters, ref. PEP 7.

Comment threadModules/_sqlite/cursor.c Outdated
Comment threadMisc/NEWS.d/next/Library/2019-06-22-11-01-45.bpo-36073.ED8mB9.rst Outdated
Comment threadLib/sqlite3/test/regression.py Outdated

@erlend-aaslanderlend-aaslandApr 8, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be rebased onto master in order to fit in with the changes in the test suite.

@sir-sigurd

sir-sigurd commented Apr 9, 2021

Copy link
Copy Markdown
ContributorAuthor

@erlend-aasland
I'll try to rebase in the near future, though I almost do not remember anything about this.

@erlend-aasland

erlend-aasland commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

I'll try to rebase in the near future, though I almost do not remember anything about this.

Thanks, there's no hurry :)

@sir-sigurd
sir-sigurdforce-pushed the sqlite-converter-segfault branch from d3a828d to c79e784CompareApril 12, 2021 08:14
erlend-aasland
erlend-aasland approved these changes Jun 16, 2021
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erlend-aasland

erlend-aasland commented Jun 16, 2021

Copy link
Copy Markdown
Contributor

@serhiy-storchaka would you mind reviewing this?

@erlend-aasland

erlend-aasland commented Aug 26, 2021

Copy link
Copy Markdown
Contributor

Could you rebase again (bco. GH-27884), @sir-sigurd? :)

Also, please clean up the regression test:

  • line length is limited to 79 chars
  • please use double quotes

@erlend-aaslanderlend-aasland mentioned this pull request Oct 19, 2021
Merged
@sir-sigurd

sir-sigurd commented Nov 17, 2021

Copy link
Copy Markdown
ContributorAuthor

Closed in favor of GH-29054.

@sir-sigurd
sir-sigurd deleted the sqlite-converter-segfault branch November 17, 2021 04:17
@sir-sigurdsir-sigurdmannequin mentioned this pull request Apr 10, 2022
Closed
heitbaum added a commit to heitbaum/LibreELEC.tv that referenced this pull request May 17, 2022
@heitbaum
Python3: update to 3.9.13
5c655c7
release:
- https://www.python.org/downloads/release/python-3913/
changelog:
- https://docs.python.org/release/3.9.13/whatsnew/changelog.html
upstream fix for dropped patch
- python/cpython#80254
- python/cpython#11984
- python/cpython#90228
- python/cpython#92036
- python/cpython#92037
- python/cpython#92297
- bpo-36073
- was
- python/cpython#30579
- python/cpython#30580
@heitbaumheitbaum mentioned this pull request May 17, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag
@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka
+2 more reviewers
@BoboTiGBoboTiGBoboTiG left review comments
@auvipyauvipyauvipy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sir-sigurd@BoboTiG@erlend-aasland@auvipy@the-knights-who-say-ni@bedevere-bot