Uh oh!
There was an error while loading. Please reload this page.
gh-119819: Fix regression to allow logging configuration with multipr… - #120030
Merged
Conversation
…ultiprocessing queue types.
Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 4, 2024
…ultipr… (pythonGH-120030) (cherry picked from commit 99d945c) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
GH-120034 is a backport of this pull request to the 3.12 branch. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 4, 2024
…ultipr… (pythonGH-120030) (cherry picked from commit 99d945c) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
GH-120035 is a backport of this pull request to the 3.13 branch. |
vsajip pushed a commit
that referenced
this pull request
Jun 4, 2024
vsajip pushed a commit
that referenced
this pull request
Jun 4, 2024
bedevere-bot
commented
Jun 4, 2024
|
mhsmith
reviewed
Jun 4, 2024
| msg = str(ctx.exception) | ||
| self.assertEqual(msg, "Unable to configure handler 'ah'") | ||
| @unittest.skipIf(support.is_wasi, "WASI does not have multiprocessing.") |
Member
There was a problem hiding this comment.
Instead of checking specifically for WASI, tests that use subprocesses should use @support.requires_subprocess().
MemberAuthor
There was a problem hiding this comment.
But this test doesn't use subprocess, only multiprocessing - I'm not sure if that requires_subprocess is appropriate. I can't (yet) tell whether the problem is inherent to the platform (iOS ARM64 Simulator) or, if I need to tighten the skip conditions for the test, exactly what the condition should be. It doesn't appear, from the tracebacks, that multiprocessing isn't supported - on WASI, for example, you get an error because _multiprocessing can't be imported. I'll do some more digging.
Member
There was a problem hiding this comment.
The error on iOS is exactly the same: see the bottom of the traceback above. The fact that multiprocessing isn't available on iOS is already mentioned in the documentation.
An even more specific check would be support.skip_if_broken_multiprocessing_synchronize(), which is already used a few times in test_logging.
MemberAuthor
There was a problem hiding this comment.
The error on iOS is exactly the same
Yes, I missed that for some reason. Perhaps the answer is to add a support.skip_if_no_multiprocessing, as support.skip_if_broken_multiprocessing_synchronize seems too specific for this particular test.
Member
There was a problem hiding this comment.
Rather than adding a specific skip function, you could just do import_helper.import_module('_multiprocessing').
bedevere-bot
commented
Jun 4, 2024
|
barneygale pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
noahbkim pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ocessing queue types.