Skip to content

Restore decimal context after decimal doctests - #120149

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:test-decimal-doctests-restore-context
Jun 6, 2024
Merged

Restore decimal context after decimal doctests#120149
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:test-decimal-doctests-restore-context

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Jun 6, 2024

Copy link
Copy Markdown
Member

The modified context caused tests failures in several other tests.

@serhiy-storchaka

serhiy-storchaka commented Jun 6, 2024

Copy link
Copy Markdown
MemberAuthor

See #117962 (comment) for details.

This is an extended variant of #120147 for main. Even if the decimal doctests do not break other tests in 3.13 and main, the context is still changed, and I believe that restoring it is the right thing.

@serhiy-storchaka
Restore decimal context after decimal doctests
6e4122f
The modified context caused tests failures in several other tests.
@serhiy-storchaka
serhiy-storchakaforce-pushed the test-decimal-doctests-restore-context branch from bfa8e85 to 6e4122fCompareJune 6, 2024 10:01
@serhiy-storchakaserhiy-storchaka mentioned this pull request Jun 6, 2024
Closed
@serhiy-storchaka

serhiy-storchaka commented Jun 6, 2024

Copy link
Copy Markdown
MemberAuthor

The root of the problem is perhaps in #89392. Before this, all decimal tests were run in test_main, which restored the context at the end. Now tests are better integrated with unittest. The cleanup code was moved to tearDownModule(), and DocTestSuite is used to run doctests. But tearDownModule() is now run before running doctests (because they are marked as belonging to other module, not test_decimal), so the context is not restored after doctests.

I still does not know why this broke other tests only in 3.12. Perhaps it is related to the import system or to reloadability of the _decimal module.

@serhiy-storchaka
serhiy-storchaka merged commit 2d7ff6e into python:mainJun 6, 2024
@serhiy-storchaka
serhiy-storchaka deleted the test-decimal-doctests-restore-context branch June 6, 2024 17:12
@serhiy-storchakaserhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jun 6, 2024
@miss-islington-app

miss-islington-appBot commented Jun 6, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Jun 6, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented Jun 6, 2024

Copy link
Copy Markdown

GH-120167 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jun 6, 2024
@bedevere-app

bedevere-appBot commented Jun 6, 2024

Copy link
Copy Markdown

GH-120168 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Jun 6, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 6, 2024
@serhiy-storchaka@miss-islington
Restore decimal context after decimal doctests (pythonGH-120149)
d96bcb7
The modified context caused tests failures in several other tests.
(cherry picked from commit 2d7ff6e)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 6, 2024
@serhiy-storchaka@miss-islington
Restore decimal context after decimal doctests (pythonGH-120149)
83bc075
The modified context caused tests failures in several other tests.
(cherry picked from commit 2d7ff6e)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jun 6, 2024
@miss-islington@serhiy-storchaka
[3.12] Restore decimal context after decimal doctests (GH-120149) (GH…
b03d71d
…-120168)
The modified context caused tests failures in several other tests.
(cherry picked from commit 2d7ff6e)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jun 6, 2024
@miss-islington@serhiy-storchaka
[3.13] Restore decimal context after decimal doctests (GH-120149) (GH…
015ddfe
…-120167)
The modified context caused tests failures in several other tests.
(cherry picked from commit 2d7ff6e)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@serhiy-storchaka@noahbkim
Restore decimal context after decimal doctests (pythonGH-120149)
08554e6
The modified context caused tests failures in several other tests.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@serhiy-storchaka@estyxx
Restore decimal context after decimal doctests (pythonGH-120149)
c6b4de9
The modified context caused tests failures in several other tests.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1sYhg1sAwaiting requested review from Yhg1s
@rhettingerrhettingerAwaiting requested review from rhettinger

Assignees

No one assigned

Labels

skip issueskip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@serhiy-storchaka