Uh oh!
There was an error while loading. Please reload this page.
gh-117657: Make PyType_HasFeature atomic - #120210
Merged
Fidget-Spinner merged 1 commit intoJun 13, 2024
Merged
Conversation
kumaraditya303
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me but haven't touched core in a while so not formally approving :)
Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 13, 2024
Make PyType_HasFeature atomic (cherry picked from commit eebae2c) Co-authored-by: Ken Jin <kenjin@python.org>
GH-120443 is a backport of this pull request to the 3.13 branch. |
Fidget-Spinner added a commit
that referenced
this pull request
Jun 13, 2024
mrahtz pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
Make PyType_HasFeature atomic
noahbkim pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
Make PyType_HasFeature atomic
estyxx pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Make PyType_HasFeature atomic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible that when a type is readying in one thread (which modify the type flags), the same type is then queried for its flags.
Here's an example from the test suite: