Skip to content

gh-120242: Fix handling of [setUp,tearDown]Class in test_datetime - #120243

Merged
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-120242
Jun 8, 2024
Merged

gh-120242: Fix handling of [setUp,tearDown]Class in test_datetime#120243
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-120242

Conversation

@sobolevn

@sobolevnsobolevn commented Jun 7, 2024

Copy link
Copy Markdown
Member

Now the example test from the original issue passes:

» ./python.exe-mtesttest_datetime-v-mtest_example_bug==CPython3.14.0a0 (heads/main-dirty:6646a9da26d, Jun72024, 13:34:08) [Clang15.0.0 (clang-1500.3.9.4)]
==macOS-14.4.1-arm64-arm-64bit-Mach-Olittle-endian==Pythonbuild: debug==cwd:/Users/sobolev/Desktop/cpython2/build/test_python_worker_65090æ==CPUcount: 12==encodings: locale=UTF-8FS=utf-8==resources: alltestresourcesaredisabled, use-uoptiontounskiptestsUsingrandomseed: 4853070490:00:00loadavg: 1.16Run1testsequentiallyinasingleprocess0:00:00loadavg: 1.16 [1/1] test_datetimetest_example_bug (test.datetimetester.TestExample_Pure.test_example_bug) ... oktest_example_bug (test.datetimetester.TestExample_Fast.test_example_bug) ... ok----------------------------------------------------------------------Ran2testsin0.000sOK==Testsresult: SUCCESS==1testOK.
Totalduration: 128msTotaltests: run=2 (filtered)
Totaltestfiles: run=1/1 (filtered)
Result: SUCCESS

Comment threadLib/test/test_datetime.py Outdated

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sobolevn
sobolevn merged commit 95f4db8 into python:mainJun 8, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2024
…etime` (pythonGH-120243)
(cherry picked from commit 95f4db8)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn

Copy link
Copy Markdown
MemberAuthor

Thanks for the reviews! 👍

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2024
…etime` (pythonGH-120243)
(cherry picked from commit 95f4db8)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app

Copy link
Copy Markdown

GH-120259 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jun 8, 2024
@bedevere-app

Copy link
Copy Markdown

GH-120260 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Jun 8, 2024
sobolevn added a commit that referenced this pull request Jun 8, 2024
…tetime` (GH-120243) (#120260)
gh-120242: Fix handling of `[setUp,tearDown]Class` in `test_datetime` (GH-120243)
(cherry picked from commit 95f4db8)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jun 8, 2024
…tetime` (GH-120243) (#120259)
gh-120242: Fix handling of `[setUp,tearDown]Class` in `test_datetime` (GH-120243)
(cherry picked from commit 95f4db8)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows11 Bigmem 3.13 has failed when building commit 863a0bd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1463/builds/118) and take a look at the build logs.
  4. Check if the failure is related to this commit (863a0bd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1463/builds/118

Failed tests:

  • test_repl

Failed subtests:

  • test_asyncio_repl_is_ok - test.test_repl.TestInteractiveInterpreter.test_asyncio_repl_is_ok

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
File "R:\buildarea\3.13.ambv-bb-win11.bigmem\build\Lib\test\test_repl.py", line 199, in test_asyncio_repl_is_ok
assert_python_ok("-m", "asyncio")
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
File "R:\buildarea\3.13.ambv-bb-win11.bigmem\build\Lib\test\support\script_helper.py", line 180, in assert_python_okreturn _assert_python(True, *args, **env_vars)
File "R:\buildarea\3.13.ambv-bb-win11.bigmem\build\Lib\test\support\script_helper.py", line 165, in _assert_python
res.fail(cmd_line)
~~~~~~~~^^^^^^^^^^
File "R:\buildarea\3.13.ambv-bb-win11.bigmem\build\Lib\test\support\script_helper.py", line 75, in failraiseAssertionError("Process return code is %d\n"...<13 lines>...
err))
AssertionError: Process return code is 2147483651
command line: ['R:\\buildarea\\3.13.ambv-bb-win11.bigmem\\build\\PCbuild\\amd64\\python_d.exe', '-X', 'faulthandler', '-I', '-m', 'asyncio']

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@bedevere-bot@ericsnowcurrently@serhiy-storchaka