Skip to content

gh-118908: Protect the REPL subprocess with a timeout in tests - #120408

Merged
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-118908-2
Jun 12, 2024
Merged

gh-118908: Protect the REPL subprocess with a timeout in tests#120408
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-118908-2

Conversation

@pablogsal

@pablogsalpablogsal commented Jun 12, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Jun 12, 2024
Open
@bedevere-appbedevere-appBot added tests Tests in the Lib/test dir awaiting core review labels Jun 12, 2024
@pablogsalpablogsal added the needs backport to 3.13 bugs and security fixes label Jun 12, 2024
vstinner
vstinner reviewed Jun 12, 2024
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadLib/test/test_pyrepl/test_pyrepl.py Outdated
pablogsal
pablogsal commented Jun 12, 2024
View reviewed changes
Comment threadLib/test/test_pyrepl/test_pyrepl.py Outdated
@pablogsal
pablogsal enabled auto-merge (squash) June 12, 2024 18:08
lysnikolaou
lysnikolaou approved these changes Jun 12, 2024
View reviewed changes

@lysnikolaoulysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pablogsal
pablogsal merged commit 3453362 into python:mainJun 12, 2024
@pablogsal
pablogsal deleted the gh-118908-2 branch June 12, 2024 19:09
@miss-islington-app

miss-islington-appBot commented Jun 12, 2024

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2024
@pablogsal@miss-islington
pythongh-118908: Protect the REPL subprocess with a timeout in tests (p…
55ba242
…ythonGH-120408)
(cherry picked from commit 3453362)
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-app

bedevere-appBot commented Jun 12, 2024

Copy link
Copy Markdown

GH-120430 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jun 12, 2024
lysnikolaou pushed a commit that referenced this pull request Jun 12, 2024
@miss-islington@pablogsal
[3.13]gh-118908: Protect the REPL subprocess with a timeout in tests (…
ff35861
…GH-120408) (#120430)
(cherry picked from commit 3453362)
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@pablogsal@mrahtz
pythongh-118908: Protect the REPL subprocess with a timeout in tests (p…
a7dc70b
…ython#120408)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@pablogsal@noahbkim
pythongh-118908: Protect the REPL subprocess with a timeout in tests (p…
f9809fa
…ython#120408)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@pablogsal@estyxx
pythongh-118908: Protect the REPL subprocess with a timeout in tests (p…
06e9e62
…ython#120408)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments
@lysnikolaoulysnikolaoulysnikolaou approved these changes
@ambvambvAwaiting requested review from ambvambv is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pablogsal@vstinner@lysnikolaou