Skip to content

gh-120417: Add #noqa: F401 to tests - #120627

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:noqa_tests
Jun 18, 2024
Merged

gh-120417: Add #noqa: F401 to tests#120627
vstinner merged 1 commit into
python:mainfrom
vstinner:noqa_tests

Conversation

@vstinner

@vstinnervstinner commented Jun 17, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Ignore linter "imported but unused" warnings in tests when the linter doesn't understand why the import is important.

@bedevere-appbedevere-appBot mentioned this pull request Jun 17, 2024
Closed
picnixz
picnixz approved these changes Jun 17, 2024
View reviewed changes
Comment threadLib/test/test_compile.py Outdated
serhiy-storchaka
serhiy-storchaka reviewed Jun 17, 2024
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import_module() can be used if ImportError is converted to SkipTest.

I have some questions about global imports of names which are seem not used in the module.

Comment threadLib/test/test___all__.py
Comment on lines 104 to +106
# In case _socket fails to build, make this test fail more gracefully
# than an AttributeError somewhere deep in concurrent.futures, email
# or unittest.
import _socket
import _socket # noqa: F401

@serhiy-storchakaserhiy-storchakaJun 17, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not using import_module() be better?

@vstinnervstinnerJun 18, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent is to get an error if the module is missing, not to skip the test.

Comment threadLib/test/test_compileall.py
# and it can function.
from multiprocessing.util import _cleanup_tests as multiprocessing_cleanup_tests
from concurrent.futures import ProcessPoolExecutor
from concurrent.futures import ProcessPoolExecutor # noqa: F401

@serhiy-storchakaserhiy-storchakaJun 17, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ProcessPoolExecutor is needed?

@vstinnervstinnerJun 17, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's explained in the comment, 2 lines above. It's a check to define _have_multiprocessing.

Comment threadLib/test/test_descrtut.py
# deterministic.

from test.support import sortdict
from test.support import sortdict # noqa: F401

@serhiy-storchakaserhiy-storchakaJun 17, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why sortdict is needed?

@vstinnervstinnerJun 17, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used in doctests.

Comment threadLib/test/test_doctest/test_doctest.py Outdated
Comment threadLib/test/test_doctest/test_doctest.py Outdated
Comment threadLib/test/test_regrtest.py Outdated
Comment threadLib/test/test_regrtest.py Outdated
Comment threadLib/test/test_regrtest.py Outdated
serhiy-storchaka
serhiy-storchaka approved these changes Jun 18, 2024
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
pythongh-120417: Add #noqa: F401 to tests
9684aa1
Ignore linter "imported but unused" warnings in tests when the linter
doesn't understand why the import is important.
@vstinner

vstinner commented Jun 18, 2024

Copy link
Copy Markdown
MemberAuthor

PR rebased to squash changes and fix merge conflicts.

@vstinner
vstinner enabled auto-merge (squash) June 18, 2024 15:23
@vstinner
vstinner merged commit e9f4d80 into python:mainJun 18, 2024
@vstinner
vstinner deleted the noqa_tests branch June 18, 2024 15:51
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jun 19, 2024
@vstinner@picnixz
pythongh-120417: Add #noqa: F401 to tests (python#120627)
694c130
Ignore linter "imported but unused" warnings in tests when the linter
doesn't understand how the import is used.
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@vstinner@mrahtz
pythongh-120417: Add #noqa: F401 to tests (python#120627)
364df97
Ignore linter "imported but unused" warnings in tests when the linter
doesn't understand how the import is used.
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@vstinner@noahbkim
pythongh-120417: Add #noqa: F401 to tests (python#120627)
382e78f
Ignore linter "imported but unused" warnings in tests when the linter
doesn't understand how the import is used.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner@estyxx
pythongh-120417: Add #noqa: F401 to tests (python#120627)
60df5cc
Ignore linter "imported but unused" warnings in tests when the linter
doesn't understand how the import is used.
@vstinnervstinner mentioned this pull request Mar 13, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@picnixzpicnixzpicnixz approved these changes
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner
@gvanrossumgvanrossumAwaiting requested review from gvanrossum
@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner
@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@serhiy-storchaka@picnixz