Skip to content

gh-120659: Skip test_freethreading with GIL - #120660

Merged
vstinner merged 6 commits into
python:mainfrom
nineteendo:skip-test_freethreading-gil
Jun 18, 2024
Merged

gh-120659: Skip test_freethreading with GIL#120660
vstinner merged 6 commits into
python:mainfrom
nineteendo:skip-test_freethreading-gil

Conversation

@nineteendo

@nineteendonineteendo commented Jun 17, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Jun 17, 2024
Closed
@nineteendonineteendo mentioned this pull request Jun 17, 2024
Closed
colesbury
colesbury reviewed Jun 17, 2024
View reviewed changes
Comment threadLib/test/test_free_threading/__init__.py Outdated
vstinner
vstinner reviewed Jun 18, 2024
View reviewed changes
Comment threadLib/test/test_free_threading/__init__.py Outdated
@nineteendo@vstinner
Raise at module level
465759a
Co-authored-by: Victor Stinner <vstinner@python.org>
@nineteendo
nineteendoforce-pushed the skip-test_freethreading-gil branch from d5633ae to 465759aCompareJune 18, 2024 07:34
@nineteendo

nineteendo commented Jun 18, 2024

Copy link
Copy Markdown
ContributorAuthor

I fixed the co-author message.

@nineteendo
nineteendo requested a review from vstinnerJune 18, 2024 08:00
@vstinner

vstinner commented Jun 18, 2024

Copy link
Copy Markdown
Member

@nineteendo nineteendo requested a review from vstinner

I don't know test_freethreading. I don't know if it makes sense to run these tests with the GIL enabled.

@nineteendo

This comment was marked as resolved.

Sign in to view
@vstinner
vstinner removed their request for review June 18, 2024 11:27
@colesbury

colesbury commented Jun 18, 2024

Copy link
Copy Markdown
Contributor

There is some value to running these tests on with the GIL enabled, but not enough to justify the time they're taking. If we make the tests faster, we can reconsider re-enabling them for the default build.

@vstinner
vstinner merged commit 360f14a into python:mainJun 18, 2024
@miss-islington-app

miss-islington-appBot commented Jun 18, 2024

Copy link
Copy Markdown

Thanks @nineteendo for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2024
@nineteendo@miss-islington
pythongh-120659: Skiptest_freethreadingwith GIL (pythonGH-120660)
1eec326
(cherry picked from commit 360f14a)
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@nineteendo
nineteendo deleted the skip-test_freethreading-gil branch June 18, 2024 13:56
@bedevere-app

bedevere-appBot commented Jun 18, 2024

Copy link
Copy Markdown

GH-120694 is a backport of this pull request to the 3.13 branch.

@vstinner

vstinner commented Jun 18, 2024

Copy link
Copy Markdown
Member

Ok, in that case, I merge the change. Thanks @nineteendo.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jun 18, 2024
vstinner pushed a commit that referenced this pull request Jun 18, 2024
@miss-islington@nineteendo
[3.13]gh-120659: Skiptest_freethreadingwith GIL (GH-120660) (#12…
4f4973d
…0694)
gh-120659: Skip `test_freethreading` with GIL (GH-120660)
(cherry picked from commit 360f14a)
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@nineteendonineteendo mentioned this pull request Jun 18, 2024
Merged
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jun 19, 2024
@nineteendo@picnixz
pythongh-120659: Skiptest_freethreadingwith GIL (python#120660)
773c86d
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@nineteendo@mrahtz
pythongh-120659: Skiptest_freethreadingwith GIL (python#120660)
f6f76d1
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@nineteendo@noahbkim
pythongh-120659: Skiptest_freethreadingwith GIL (python#120660)
fed6ee4
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@nineteendo@estyxx
pythongh-120659: Skiptest_freethreadingwith GIL (python#120660)
ba3a072
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments
@colesburycolesburycolesbury approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nineteendo@vstinner@colesbury