Uh oh!
There was an error while loading. Please reload this page.
gh-119786: move frames documentation to InternalDocs and add details - #121009
Conversation
markshannon
left a comment
There was a problem hiding this comment.
I've a few suggestions.
Also, FYI:
f_globalsandf_builtinsare likely to be removed soon faster-cpython/ideas#661- We may even move to a two-stack approach faster-cpython/ideas#675
| * Local variables (including arguments, cells and free variables) | ||
| * Evaluation stack | ||
| * Evaluation stack and instruction pointer |
There was a problem hiding this comment.
I don't think the instruction pointer belongs here (at least not conceptually).
I would add it to specials/linkage
There was a problem hiding this comment.
How about I change this line to
Execution state: evaluation stack, instruction pointer ?
It feels like instruction pointer is internal to the frame's working, rather than linking to external frames or objects.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
markshannon
commented
Jun 26, 2024
I think it would make sense to merge the "specials" and "linkage" sections. The only real "linkage" is the So, maybe replace "specials and linkage" with "specials", and when specifically referring to "linkage", say |
Uh oh!
There was an error while loading. Please reload this page.