Skip to content

gh-121016: Add test for PYTHON_BASIC_REPL envioronment variable - #121017

Merged
AlexWaygood merged 3 commits into
python:mainfrom
devdanzin:test_python_basic_repl
Jun 26, 2024
Merged

gh-121016: Add test for PYTHON_BASIC_REPL envioronment variable#121017
AlexWaygood merged 3 commits into
python:mainfrom
devdanzin:test_python_basic_repl

Conversation

@devdanzin

@devdanzindevdanzin commented Jun 26, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This PR adds a test for PYTHON_BASIC_REPL setting the interpreter to use the basic REPL, using a technique suggested by @AlexWaygood on Discord.

@bedevere-appbedevere-appBot mentioned this pull request Jun 26, 2024
Closed
lysnikolaou
lysnikolaou approved these changes Jun 26, 2024
View reviewed changes

@lysnikolaoulysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @devdanzin!

@lysnikolaoulysnikolaou added needs backport to 3.13 bugs and security fixes topic-repl Related to the interactive shell labels Jun 26, 2024
AlexWaygood
AlexWaygood reviewed Jun 26, 2024
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Two tiny nits:

Comment threadLib/test/test_pyrepl/test_pyrepl.py
Comment threadLib/test/test_pyrepl/test_pyrepl.py
@devdanzin@AlexWaygood
Apply suggestions from code review to double-check that the tests are…
0f0ee39
… working as expected.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@devdanzin

devdanzin commented Jun 26, 2024

Copy link
Copy Markdown
MemberAuthor

Thank you Lysandros and Alex!

@AlexWaygoodAlexWaygood changed the title gh-121016: Test PYTHON_BASIC_REPLgh-121016: Add test for PYTHON_BASIC_REPL envioronment variableJun 26, 2024
@AlexWaygood
AlexWaygood enabled auto-merge (squash) June 26, 2024 09:59
@AlexWaygood
AlexWaygood merged commit 9e45fd9 into python:mainJun 26, 2024
@miss-islington-app

miss-islington-appBot commented Jun 26, 2024

Copy link
Copy Markdown

Thanks @devdanzin for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Jun 26, 2024

Copy link
Copy Markdown

Sorry, @devdanzin and @AlexWaygood, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9e45fd9858a059950f7387b4fda2b00df0e8e537 3.13

@AlexWaygood

AlexWaygood commented Jun 26, 2024

Copy link
Copy Markdown
Member

@devdanzin, would you possibly be able to take care of the backport PR? If you're not familiar with the process, I can do it later

@devdanzin

devdanzin commented Jun 26, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks for merging!

@devdanzin, would you possibly be able to take care of the backport PR?

I'm not sure I can, I get "Permission denied" at the end of the process:

🐍 🍒 ⛏
Failed to push to origin ☹
branch backport-9e45fd9-3.13 has been deleted.
Backport PR:
[3.13] gh-121016: Add test for `PYTHON_BASIC_REPL` envioronment variable (GH-121017)
(cherry picked from commit 9e45fd9858a059950f7387b4fda2b00df0e8e537)
Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
remote: Permission to python/cpython.git denied to devdanzin.
fatal: unable to access 'https://github.com/python/cpython.git/': The requested URL returned error: 403

If the right way to do it is to push to my fork first, I can try it tonight. Otherwise, feel free to handle it.

@lysnikolaou

lysnikolaou commented Jun 26, 2024

Copy link
Copy Markdown
Member

If the right way to do it is to push to my fork first, I can try it tonight. Otherwise, feel free to handle it.

That's the right way, yes. You can try it tonight, sure.

devdanzin added a commit to devdanzin/cpython that referenced this pull request Jun 26, 2024
@devdanzin
pythongh-121016: Add test forPYTHON_BASIC_REPLenvioronment variab…
547f13d
…le (python#121017)
(cherry picked from commit 9e45fd9)
devdanzin added a commit to devdanzin/cpython that referenced this pull request Jun 26, 2024
@devdanzin
[3.13]pythongh-121016: Add test forPYTHON_BASIC_REPLenvioronment…
1ac30d5
… variable (pythonGH-121017)
(cherry picked from commit 9e45fd9)
Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
devdanzin added a commit to devdanzin/cpython that referenced this pull request Jun 26, 2024
@devdanzin
pythongh-121016: Add test forPYTHON_BASIC_REPLenvioronment variab…
4ecdb52
…le (python#121017)
(cherry picked from commit 9e45fd9)
devdanzin added a commit to devdanzin/cpython that referenced this pull request Jun 26, 2024
@devdanzin
[3.13]pythongh-121016: Add test forPYTHON_BASIC_REPLenvioronment…
65f456b
… variable (pythonGH-121017)
(cherry picked from commit 9e45fd9)
Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Jun 26, 2024

Copy link
Copy Markdown

GH-121064 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jun 26, 2024
AlexWaygood pushed a commit that referenced this pull request Jun 26, 2024
@devdanzin
[3.13]gh-121016: Add test for PYTHON_BASIC_REPL envioronment variable (
bc515b3
GH-121017) (#121064)
* gh-121016: Add test for `PYTHON_BASIC_REPL` envioronment variable (#121017)
(cherry picked from commit 9e45fd9)
* [3.13] gh-121016: Add test for `PYTHON_BASIC_REPL` envioronment variable (GH-121017)
(cherry picked from commit 9e45fd9)
Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@devdanzin@mrahtz
pythongh-121016: Add test forPYTHON_BASIC_REPLenvioronment variab…
bcd4204
…le (python#121017)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@devdanzin@noahbkim
pythongh-121016: Add test forPYTHON_BASIC_REPLenvioronment variab…
0bbf153
…le (python#121017)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@devdanzin@estyxx
pythongh-121016: Add test forPYTHON_BASIC_REPLenvioronment variab…
73474bb
…le (python#121017)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaoulysnikolaoulysnikolaou approved these changes
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes
@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner
@ambvambvAwaiting requested review from ambvambv is a code owner

Assignees

@AlexWaygoodAlexWaygood

Labels

skip newstopic-replRelated to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devdanzin@AlexWaygood@lysnikolaou@sobolevn