Uh oh!
There was an error while loading. Please reload this page.
gh-121040: Use __attribute__((fallthrough)) - #121044
Merged
Merged
Conversation
Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses __attribute__((fallthrough)) if available. Fix warnings when using -Wimplicit-fallthrough compiler flag.
vstinner
requested review from
brettcannon, corona10, ericsnowcurrently, gpshead, iritkatriel, markshannon, ncoghlan, tiran and warsaw
as code ownersJune 26, 2024 12:52
vstinner
commented
Jun 26, 2024
MemberAuthor
cc @sobolevn |
sobolevn
left a comment
Member
There was a problem hiding this comment.
Looks like you need to run make regen-cases (or maybe even make regen-all) :)
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
Jun 26, 2024
MemberAuthor
Done. |
mdboom
commented
Jun 26, 2024
Contributor
Maybe of interest to @nohlson. |
Uh oh!
There was an error while loading. Please reload this page.
No longer define __has_attribute() if it's not defined. Move also _Py__has_builtin() at the top of pyport.h.
ericsnowcurrently
approved these changes
Jun 26, 2024
ericsnowcurrently
left a comment
Member
There was a problem hiding this comment.
LGTM
I left one small comment where you might consider a slightly different spelling, but I'll leave that up to you.
Uh oh!
There was an error while loading. Please reload this page.
brettcannon
removed their request for review
June 26, 2024 17:35
vstinner
enabled auto-merge (squash)
June 27, 2024 09:38
vstinner
commented
Jun 27, 2024
MemberAuthor
I tested my change with See also the article about the flag: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7 |
mrahtz pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
Fix warnings when using -Wimplicit-fallthrough compiler flag. Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses __attribute__((fallthrough)) if available. Replace "fall through" comments with _Py_FALLTHROUGH. Add _Py__has_attribute() macro. No longer define __has_attribute() macro if it's not defined. Move also _Py__has_builtin() at the top of pyport.h. Co-Authored-By: Nikita Sobolev <mail@sobolevn.me>
noahbkim pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
Fix warnings when using -Wimplicit-fallthrough compiler flag. Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses __attribute__((fallthrough)) if available. Replace "fall through" comments with _Py_FALLTHROUGH. Add _Py__has_attribute() macro. No longer define __has_attribute() macro if it's not defined. Move also _Py__has_builtin() at the top of pyport.h. Co-Authored-By: Nikita Sobolev <mail@sobolevn.me>
estyxx pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Fix warnings when using -Wimplicit-fallthrough compiler flag. Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses __attribute__((fallthrough)) if available. Replace "fall through" comments with _Py_FALLTHROUGH. Add _Py__has_attribute() macro. No longer define __has_attribute() macro if it's not defined. Move also _Py__has_builtin() at the top of pyport.h. Co-Authored-By: Nikita Sobolev <mail@sobolevn.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotate explicitly "fall through" switch cases with a new _Py_FALLTHROUGH macro which uses attribute((fallthrough)) if available.
Fix warnings when using -Wimplicit-fallthrough compiler flag.