Skip to content

gh-121082: Fix build failure when the developer use --enable-pystats arguments in configuration command after #118450 - #121083

Merged
Fidget-Spinner merged 5 commits into
python:mainfrom
Zheaoli:manjusaka/gh121082
Jun 27, 2024
Merged

gh-121082: Fix build failure when the developer use --enable-pystats arguments in configuration command after #118450#121083
Fidget-Spinner merged 5 commits into
python:mainfrom
Zheaoli:manjusaka/gh121082

Conversation

@Zheaoli

@ZheaoliZheaoli commented Jun 27, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@Zheaoli
Fix build failure when the developer use --enable-pystats arguments…
67a8f6f
… in configuration command after python#118450
Signed-off-by: Manjusaka <me@manjusaka.me>
@ZheaoliZheaoli changed the title Fix build failure when the developer use --enable-pystats arguments in configuration command after #118450gh121082: Fix build failure when the developer use --enable-pystats arguments in configuration command after #118450Jun 27, 2024
@ZheaoliZheaoli changed the title gh121082: Fix build failure when the developer use --enable-pystats arguments in configuration command after #118450GH-121082: Fix build failure when the developer use --enable-pystats arguments in configuration command after #118450Jun 27, 2024
@bedevere-appbedevere-appBot mentioned this pull request Jun 27, 2024
Closed
@ZheaoliZheaoli changed the title GH-121082: Fix build failure when the developer use --enable-pystats arguments in configuration command after #118450gh-121082: Fix build failure when the developer use --enable-pystats arguments in configuration command after #118450Jun 27, 2024
@Zheaoli
fix docs lint
8765ccc
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Fix docs lint error
ac7a385
Fidget-Spinner
Fidget-Spinner reviewed Jun 27, 2024
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one minor nit

Comment threadPython/specialize.c Outdated
Fidget-Spinner
Fidget-Spinner reviewed Jun 27, 2024
View reviewed changes
Comment threadPython/specialize.c Outdated
Comment threadPython/specialize.c Outdated
Comment threadPython/specialize.c Outdated
@Zheaoli

Zheaoli commented Jun 27, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks! Just one minor nit

Thanks for the tips!

@Fidget-Spinner
Fidget-Spinner merged commit 223c03a into python:mainJun 27, 2024
@Zheaoli
Zheaoli deleted the manjusaka/gh121082 branch June 27, 2024 11:36
@Fidget-SpinnerFidget-Spinner mentioned this pull request Jun 27, 2024
Open
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@Zheaoli@Fidget-Spinner@mrahtz
pythongh-121082: Fix build failure when the developer use `--enable-p…
794f146
…ystats` arguments in configuration command after python#118450 (python#121083)
Signed-off-by: Manjusaka <me@manjusaka.me>
Co-authored-by: Ken Jin <kenjin4096@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@Zheaoli@Fidget-Spinner@noahbkim
pythongh-121082: Fix build failure when the developer use `--enable-p…
801de26
…ystats` arguments in configuration command after python#118450 (python#121083)
Signed-off-by: Manjusaka <me@manjusaka.me>
Co-authored-by: Ken Jin <kenjin4096@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Zheaoli@Fidget-Spinner@estyxx
pythongh-121082: Fix build failure when the developer use `--enable-p…
7aea987
…ystats` arguments in configuration command after python#118450 (python#121083)
Signed-off-by: Manjusaka <me@manjusaka.me>
Co-authored-by: Ken Jin <kenjin4096@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CPython build failed with --enable-pystats after #118450

2 participants

@Zheaoli@Fidget-Spinner