Skip to content

gh-61103: Support float and long double complex types in ctypes module - #121248

Merged
vstinner merged 7 commits into
python:mainfrom
skirpichev:ctypes-floatlong-complex-61103
Jul 3, 2024
Merged

gh-61103: Support float and long double complex types in ctypes module#121248
vstinner merged 7 commits into
python:mainfrom
skirpichev:ctypes-floatlong-complex-61103

Conversation

@skirpichev

@skirpichevskirpichev commented Jul 2, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

This amends 6988ff0: memory allocation for stginfo->ffi_type_pointer.elements in PyCSimpleType_init() should be more generic (perhaps someday fmt->pffi_type->elements will be not a two-elements array).

It should finally resolve#61103.

📚 Documentation preview 📚: https://cpython-previews--121248.org.readthedocs.build/

@skirpichev
pythongh-61103: Support float and long double complex types in ctypes…
20355d6
… module
This amends 6988ff0: memory allocation for
stginfo->ffi_type_pointer.elements in PyCSimpleType_init() should be
more generic (perhaps someday fmt->pffi_type->elements will be not a
two-elements array).
It should finally resolvepython#61103.
@bedevere-appbedevere-appBot mentioned this pull request Jul 2, 2024
Closed
@nineteendo

nineteendo commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

Looking good, if merged this would fix the table of complex types only having a single row.

vstinner
vstinner reviewed Jul 2, 2024
View reviewed changes
Comment threadLib/test/test_ctypes/test_libc.py
Comment threadLib/test/test_ctypes/test_libc.py
Comment threadLib/test/test_ctypes/test_numbers.py
Comment threadLib/test/test_ctypes/test_numbers.py Outdated
Comment threadModules/_complex.h
Comment threadModules/_complex.h
Comment threadModules/_ctypes/_ctypes_test.c
Comment threadModules/_ctypes/_ctypes_test.c
skirpichevand others added 2 commits July 2, 2024 11:04
@skirpichev@vstinner
Apply suggestions from code review
a8f25ea
Co-authored-by: Victor Stinner <vstinner@python.org>
@skirpichev
address review: mostly newlines)
16bb4bd
vstinner
vstinner reviewed Jul 2, 2024
View reviewed changes
Comment threadLib/test/test_ctypes/test_numbers.py Outdated
vstinner
vstinner reviewed Jul 2, 2024
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2024-07-02-05-08-16.gh-issue-61103.TMxkuM.rst Outdated
skirpichev
skirpichev commented Jul 2, 2024
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2024-06-23-07-23-08.gh-issue-61103.ca_U_l.rst Outdated
picnixz
picnixz reviewed Jul 2, 2024
View reviewed changes
Comment threadDoc/library/ctypes.rst
Comment threadMisc/NEWS.d/next/Library/2024-06-23-07-23-08.gh-issue-61103.ca_U_l.rst Outdated
@skirpichev@picnixz
Apply suggestions from code review
061c45b
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
vstinner
vstinner approved these changes Jul 3, 2024
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
vstinner merged commit 51c4a32 into python:mainJul 3, 2024
@skirpichev
skirpichev deleted the ctypes-floatlong-complex-61103 branch July 3, 2024 09:23
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@skirpichev@vstinner
@picnixz@noahbkim
pythongh-61103: Support float and long double complex types in ctypes…
397ee93
… module (python#121248)
This amends 6988ff0: memory allocation for
stginfo->ffi_type_pointer.elements in PyCSimpleType_init() should be
more generic (perhaps someday fmt->pffi_type->elements will be not a
two-elements array).
It should finally resolvepython#61103.
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@skirpichev@vstinner
@picnixz@estyxx
pythongh-61103: Support float and long double complex types in ctypes…
1e01436
… module (python#121248)
This amends 6988ff0: memory allocation for
stginfo->ffi_type_pointer.elements in PyCSimpleType_init() should be
more generic (perhaps someday fmt->pffi_type->elements will be not a
two-elements array).
It should finally resolvepython#61103.
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments
@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for C99 complex type (_Complex) as ctypes.c_complex

4 participants

@skirpichev@nineteendo@vstinner@picnixz