Skip to content

gh-121035: Improve logging flow diagram for dark/light modes. - #121254

Merged
vsajip merged 1 commit into
python:mainfrom
vsajip:logging-flow-diagram
Jul 2, 2024
Merged

gh-121035: Improve logging flow diagram for dark/light modes.#121254
vsajip merged 1 commit into
python:mainfrom
vsajip:logging-flow-diagram

Conversation

@vsajip

@vsajipvsajip commented Jul 2, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@vsajipvsajip added docs Documentation in the Doc dir skip news labels Jul 2, 2024
@vsajipvsajip self-assigned this Jul 2, 2024
@bedevere-appbedevere-appBot mentioned this pull request Jul 2, 2024
Closed
@vsajip
vsajip merged commit bfe0e4d into python:mainJul 2, 2024
@vsajip
vsajip deleted the logging-flow-diagram branch July 2, 2024 08:13
@vsajipvsajip added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 2, 2024
@miss-islington-app

miss-islington-appBot commented Jul 2, 2024

Copy link
Copy Markdown

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

miss-islington-appBot commented Jul 2, 2024

Copy link
Copy Markdown

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@vsajipvsajip added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 2, 2024
@miss-islington-app

miss-islington-appBot commented Jul 2, 2024

Copy link
Copy Markdown

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Jul 2, 2024

Copy link
Copy Markdown

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@vsajipvsajip mentioned this pull request Jul 2, 2024
Merged
@bessman

bessman commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

This does not work for me with the combination of browser dark mode + light theme selected via drop down. The diagram rendered as white on white in this case.

It does work for browser light mode + dark theme selected via drop down, however.

@vsajip

vsajip commented Jul 2, 2024

Copy link
Copy Markdown
MemberAuthor

OK, thanks for the feedback. I'll look at that case.

@vsajip

vsajip commented Jul 2, 2024

Copy link
Copy Markdown
MemberAuthor

I have a new PR, #121265 - it should fix the problem. Please feel free to try it out.

I created some screenshots: In the following, names are X-Y where the X is the browser (Firefox) mode and Y is the theme selector value.

auto-auto:
auto-auto

auto-light:
auto-light

auto-dark:
auto-dark

light-auto:
light-auto

light-light:
light-light

light-dark:
light-dark

dark-auto:
dark-auto

dark-light:
dark-light

dark-dark:
dark-dark

Akasurde pushed a commit to Akasurde/cpython that referenced this pull request Jul 3, 2024
@vsajip@Akasurde
pythongh-121035: Improve logging flow diagram for dark/light modes. (p…
0972089
…ythonGH-121254)
vsajip added a commit to vsajip/cpython that referenced this pull request Jul 3, 2024
@vsajip
[3.12]pythongh-121035: Improve logging flow diagram for dark/light m…
bd43fcf
…odes. (pythonGH-121254)
(cherry picked from commit bfe0e4d)
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
@vsajipvsajip mentioned this pull request Jul 3, 2024
Merged
@bedevere-app

bedevere-appBot commented Jul 3, 2024

Copy link
Copy Markdown

GH-121316 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Jul 3, 2024
vsajip added a commit to vsajip/cpython that referenced this pull request Jul 3, 2024
@vsajip
[3.13]pythongh-121035: Improve logging flow diagram for dark/light m…
845d861
…odes. (pythonGH-121254)
(cherry picked from commit bfe0e4d)
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
@vsajipvsajip mentioned this pull request Jul 3, 2024
Merged
@bedevere-app

bedevere-appBot commented Jul 3, 2024

Copy link
Copy Markdown

GH-121317 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jul 3, 2024
vsajip added a commit that referenced this pull request Jul 3, 2024
@vsajip
[3.12]gh-121035: Improve logging flow diagram for dark/light modes. (G…
c3f393c
…H-121254) (GH-121316)
(cherry picked from commit bfe0e4d)
vsajip added a commit that referenced this pull request Jul 3, 2024
@vsajip
[3.13]gh-121035: Improve logging flow diagram for dark/light modes. (G…
b62605d
…H-121254) (GH-121317)
(cherry picked from commit bfe0e4d)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@vsajip@noahbkim
pythongh-121035: Improve logging flow diagram for dark/light modes. (p…
7365546
…ythonGH-121254)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vsajip@estyxx
pythongh-121035: Improve logging flow diagram for dark/light modes. (p…
aa70c04
…ythonGH-121254)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vsajipvsajip

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vsajip@bessman