Uh oh!
There was an error while loading. Please reload this page.
gh-121045: Use link test to check whether -fstack-protector-strong works - #121258
gh-121045: Use link test to check whether -fstack-protector-strong works#121258ayappanec wants to merge 11 commits into
Conversation
ayappanec
commented
Jul 2, 2024
I didn't add NEWS entry as this is a minor change. |
corona10
commented
Jul 2, 2024
cc @nohlson |
ayappanec
commented
Jul 15, 2024
Any update on this ? |
erlend-aasland
left a comment
There was a problem hiding this comment.
Instead of hard-coding this to the AIX platform, I would prefer if we could instead rewrite the check to also run the linker, so it would fail on any platform that requires the linker step in order to determine support for this flag. Maybe a configure macro similar to PY_CHECK_CC_WARNING should be added: PY_CHECK_CC_FLAG?
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
ayappanec
commented
Jul 22, 2024
I have made the requested changes; please review again |
Thanks for making the requested changes! @erlend-aasland: please review the changes made to this pull request. |
ayappanec
commented
Jul 29, 2024
Kindly requesting for reviews |
erlend-aasland
commented
Jul 31, 2024
Sorry, my bandwidth is low these days; I won't be able to revisit these for the next few weeks. Ping me again mid August if I don't get back to you. Thanks for your patience. |
Uh oh!
There was an error while loading. Please reload this page.
ayappanec
commented
Sep 2, 2024
ayappanec
commented
Sep 17, 2024
Kindly requesting for reviews |
1 similar comment
ayappanec
commented
Oct 1, 2024
Kindly requesting for reviews |
ayappanec
commented
Apr 22, 2025
Closing this PR as it is not getting any attention. Also I think the best way to address this issue is to fix the gcc compiler in AIX, so that during compile stage only (-c) it should fail when -fstack-protector-strong is passed. |
This PR is to fix the problem mentioned in the issue #121045.
-fstack-protector-strong is not supported in AIX for gcc compiler and it actually requires a run/link check rather than a compile check to confirm it. And also there is no plan as of now to make it supported in AIX for gcc.