Skip to content

gh-119909: Fix NameError in asyncio REPL - #121341

Merged
ambv merged 1 commit into
python:mainfrom
Eclips4:issue-119909
Jul 6, 2024
Merged

gh-119909: Fix NameError in asyncio REPL#121341
ambv merged 1 commit into
python:mainfrom
Eclips4:issue-119909

Conversation

@Eclips4

@Eclips4Eclips4 commented Jul 3, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Seems that was a culprit, with that I cannot reproduce failure in test_asyncio_repl_is_ok:

./python-mtest-R100:100test_repltest_list-j2Usingrandomseed: 9850225350:00:00loadavg: 0.21Run2testsinparallelusing2workerprocesses0:00:30loadavg: 0.92running (2): test_repl (30.0sec), test_list (30.0sec)
0:01:00loadavg: 1.34running (2): test_repl (1min), test_list (1min)
0:01:30loadavg: 1.60running (2): test_repl (1min30sec), test_list (1min30sec)
0:01:55loadavg: 1.74 [1/2] test_listpassed (1min55sec) --running (1): test_repl (1min55sec)
beginning200repetitions. Showingnumberofleaks (. for0orless, Xfor10ormore)
1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890:1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890XX.................................................................................................. ....................................................................................................
0:02:25loadavg: 1.45running (1): test_repl (2min25sec)
0:02:55loadavg: 1.27running (1): test_repl (2min55sec)
0:03:23loadavg: 1.16 [2/2] test_replpassed (3min23sec)
beginning200repetitions. Showingnumberofleaks (. for0orless, Xfor10ormore)
1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890:1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890XX.................................................................................................. ....................................................................................................
==Testsresult: SUCCESS==All2testsOK.
Totalduration: 3min23secTotaltests: run=70Totaltestfiles: run=2/2Result: SUCCESS

@Eclips4
Eclips4 requested a review from ambvJuly 3, 2024 17:33
@bedevere-appbedevere-appBot mentioned this pull request Jul 3, 2024
Closed
Eclips4
Eclips4 commented Jul 3, 2024
View reviewed changes
Comment threadLib/asyncio/__main__.py
raise RuntimeError(err)
except Exception as e:
console.interact(banner="", exitmsg=exit_message)
console.interact(banner="", exitmsg="")

@Eclips4Eclips4Jul 3, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tough, not sure which exitmsg would be appropriate there.

@Eclips4Eclips4 mentioned this pull request Jul 6, 2024
Closed
@Eclips4Eclips4 added the needs backport to 3.13 bugs and security fixes label Jul 6, 2024
@ambv
ambv merged commit 1143894 into python:mainJul 6, 2024
@miss-islington-app

miss-islington-appBot commented Jul 6, 2024

Copy link
Copy Markdown

Thanks @Eclips4 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2024
@Eclips4@miss-islington
pythongh-119909: FixNameErrorinasyncioREPL (pythonGH-121341)
ab9ccbe
(cherry picked from commit 1143894)
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-app

bedevere-appBot commented Jul 6, 2024

Copy link
Copy Markdown

GH-121447 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jul 6, 2024
vstinner pushed a commit that referenced this pull request Jul 6, 2024
@miss-islington@Eclips4
[3.13]gh-119909: FixNameErrorinasyncioREPL (GH-121341) (#…
c2ad5fd
…121447)
gh-119909: Fix ``NameError`` in ``asyncio`` REPL (GH-121341)
(cherry picked from commit 1143894)
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@Eclips4@noahbkim
pythongh-119909: FixNameErrorinasyncioREPL (python#121341)
78193f3
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Eclips4@estyxx
pythongh-119909: FixNameErrorinasyncioREPL (python#121341)
0108bfd
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambvambvAwaiting requested review from ambv

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Eclips4@ambv