Skip to content

gh-117657: Skip test when running under TSan - #121549

Merged
gpshead merged 2 commits into
python:mainfrom
colesbury:gh-117657-concurrent-futures-init
Jul 9, 2024
Merged

gh-117657: Skip test when running under TSan#121549
gpshead merged 2 commits into
python:mainfrom
colesbury:gh-117657-concurrent-futures-init

Conversation

@colesbury

@colesburycolesbury commented Jul 9, 2024

Copy link
Copy Markdown
Contributor

The ProcessPoolForkserver and test_multiprocessing_fork tests use thread after forking in a multi-threaded program, which is not supported by TSan.

The ProcessPoolForkserver combined with resource_tracker starts a thread
after forking, which is not supported by TSan.
@colesbury
colesbury requested a review from gpshead as a code ownerJuly 9, 2024 20:34
@gpshead
gpshead merged commit 0439743 into python:mainJul 9, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @colesbury for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2024
The ProcessPoolForkserver combined with resource_tracker starts a thread
after forking, which is not supported by TSan.
Also skip test_multiprocessing_fork for the same reason
(cherry picked from commit 0439743)
Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app

Copy link
Copy Markdown

GH-121553 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jul 9, 2024
gpshead pushed a commit that referenced this pull request Jul 9, 2024
…21553)
gh-117657: Skip test when running under TSan (GH-121549)
The ProcessPoolForkserver combined with resource_tracker starts a thread
after forking, which is not supported by TSan.
Also skip test_multiprocessing_fork for the same reason
(cherry picked from commit 0439743)
Co-authored-by: Sam Gross <colesbury@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
The ProcessPoolForkserver combined with resource_tracker starts a thread
after forking, which is not supported by TSan.
Also skip test_multiprocessing_fork for the same reason
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
The ProcessPoolForkserver combined with resource_tracker starts a thread
after forking, which is not supported by TSan.
Also skip test_multiprocessing_fork for the same reason
@colesbury
colesbury deleted the gh-117657-concurrent-futures-init branch July 22, 2024 16:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dirtopic-free-threading

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@colesbury@gpshead