Skip to content

gh-117657: Fix TSan race in _PyDict_CheckConsistency - #121551

Merged
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-117657-dict
Jul 10, 2024
Merged

gh-117657: Fix TSan race in _PyDict_CheckConsistency#121551
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-117657-dict

Conversation

@colesbury

@colesburycolesbury commented Jul 9, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

The only remaining race in dictobject.c was in _PyDict_CheckConsistency when the dictionary has shared keys.

@colesbury
pythongh-117657: Fix TSan race in _PyDict_CheckConsistency
e119e40
The only remaining race in dictobject.c was in _PyDict_CheckConsistency
when the dictionary has shared keys.
@colesbury
colesbury requested a review from DinoVJuly 9, 2024 20:31
@bedevere-appbedevere-appBot mentioned this pull request Jul 9, 2024
Closed
@colesbury
colesbury merged commit 3ec719f into python:mainJul 10, 2024
@miss-islington-app

miss-islington-appBot commented Jul 10, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@colesbury
colesbury deleted the gh-117657-dict branch July 10, 2024 18:04
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 10, 2024
@colesbury@miss-islington
pythongh-117657: Fix TSan race in _PyDict_CheckConsistency (pythonGH-…
b12d175
…121551)
The only remaining race in dictobject.c was in _PyDict_CheckConsistency
when the dictionary has shared keys.
(cherry picked from commit 3ec719f)
Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app

bedevere-appBot commented Jul 10, 2024

Copy link
Copy Markdown

GH-121590 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jul 10, 2024
colesbury added a commit that referenced this pull request Jul 10, 2024
@miss-islington@colesbury
[3.13]gh-117657: Fix TSan race in _PyDict_CheckConsistency (GH-121551)…
927f882
… (#121590)
The only remaining race in dictobject.c was in _PyDict_CheckConsistency
when the dictionary has shared keys.
(cherry picked from commit 3ec719f)
Co-authored-by: Sam Gross <colesbury@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@colesbury@noahbkim
pythongh-117657: Fix TSan race in _PyDict_CheckConsistency (python#12…
bdcf00f
…1551)
The only remaining race in dictobject.c was in _PyDict_CheckConsistency
when the dictionary has shared keys.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@colesbury@estyxx
pythongh-117657: Fix TSan race in _PyDict_CheckConsistency (python#12…
c744960
…1551)
The only remaining race in dictobject.c was in _PyDict_CheckConsistency
when the dictionary has shared keys.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes
@DinoVDinoVAwaiting requested review from DinoV
@methanemethaneAwaiting requested review from methanemethane is a code owner
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@colesbury@Fidget-Spinner