Skip to content

gh-117657: Skip tests that fork with threads under TSan - #121599

Merged
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-117657-logging
Jul 15, 2024
Merged

gh-117657: Skip tests that fork with threads under TSan#121599
colesbury merged 1 commit into
python:mainfrom
colesbury:gh-117657-logging

Conversation

@colesbury

@colesburycolesbury commented Jul 10, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This avoids failures with messages like:

ThreadSanitizer: starting new threads after multi-threaded fork is not supported. Dying (set die_after_fork=0 to override)

@colesbury
pythongh-117657: Skip tests that fork with threads under TSan
43e43a4
This avoids messages like:
ThreadSanitizer: starting new threads after multi-threaded fork is not
supported. Dying (set die_after_fork=0 to override)
@colesbury
colesbury requested a review from vsajip as a code ownerJuly 10, 2024 21:09
@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label Jul 10, 2024
@bedevere-appbedevere-appBot mentioned this pull request Jul 10, 2024
Closed
@colesbury
colesbury requested a review from DinoVJuly 10, 2024 21:09
DinoV
DinoV approved these changes Jul 15, 2024
View reviewed changes

@DinoVDinoV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@colesbury
colesbury merged commit 82a4dac into python:mainJul 15, 2024
@miss-islington-app

miss-islington-appBot commented Jul 15, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@colesbury
colesbury deleted the gh-117657-logging branch July 15, 2024 20:43
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2024
@colesbury@miss-islington
pythongh-117657: Skip tests that fork with threads under TSan (python…
732ab54
…GH-121599)
This avoids messages like:
ThreadSanitizer: starting new threads after multi-threaded fork is not
supported. Dying (set die_after_fork=0 to override)
(cherry picked from commit 82a4dac)
Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app

bedevere-appBot commented Jul 15, 2024

Copy link
Copy Markdown

GH-121819 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jul 15, 2024
colesbury added a commit that referenced this pull request Jul 15, 2024
@miss-islington@colesbury
[3.13]gh-117657: Skip tests that fork with threads under TSan (GH-12…
6396c77
…1599) (#121819)
This avoids messages like:
ThreadSanitizer: starting new threads after multi-threaded fork is not
supported. Dying (set die_after_fork=0 to override)
(cherry picked from commit 82a4dac)
Co-authored-by: Sam Gross <colesbury@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@colesbury@estyxx
pythongh-117657: Skip tests that fork with threads under TSan (python…
dede1fc
…#121599)
This avoids messages like:
ThreadSanitizer: starting new threads after multi-threaded fork is not
supported. Dying (set die_after_fork=0 to override)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DinoVDinoVDinoV approved these changes
@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@colesbury@DinoV