Skip to content

gh-121637: Syntax error for optimized-away incorrect await - #121656

Merged
JelleZijlstra merged 10 commits into
python:mainfrom
JelleZijlstra:toplevelawait
Jul 22, 2024
Merged

gh-121637: Syntax error for optimized-away incorrect await#121656
JelleZijlstra merged 10 commits into
python:mainfrom
JelleZijlstra:toplevelawait

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented Jul 13, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Jul 13, 2024
Closed
@JelleZijlstraJelleZijlstra changed the title gh-121637: Syntax error for optimized-away incorrect await'gh-121637: Syntax error for optimized-away incorrect awaitJul 13, 2024
picnixz
picnixz reviewed Jul 13, 2024
View reviewed changes

@picnixzpicnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

Comment threadDoc/whatsnew/3.14.rst Outdated
Comment threadPython/compile.c Outdated
Comment threadPython/symtable.c Outdated
Comment threadPython/symtable.c Outdated
Comment threadPython/symtable.c Outdated
Comment threadPython/symtable.c
Comment threadPython/symtable.c Outdated
Comment threadPython/symtable.c
Comment threadMisc/NEWS.d/next/Core and Builtins/2024-07-12-18-18-44.gh-issue-121297.67VE7b.rst Outdated
@JelleZijlstra
JelleZijlstra marked this pull request as draft July 13, 2024 01:40
JelleZijlstraand others added 2 commits July 12, 2024 18:40
@JelleZijlstra@picnixz
Apply suggestions from code review
e226b56
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@JelleZijlstra
not not no but no
07d5488
@JelleZijlstra

JelleZijlstra commented Jul 13, 2024

Copy link
Copy Markdown
MemberAuthor

@picnixz while you're here, would you mind emailing me (jelle.zijlstra@gmail.com) or sending me a DM on https://discuss.python.org/u/jelle? I have something I want to ask you.

@JelleZijlstra
JelleZijlstra marked this pull request as ready for review July 13, 2024 02:04
@picnixz

picnixz commented Jul 13, 2024

Copy link
Copy Markdown
Member

while you're here, would you mind emailing me

Well.. I just went to sleep at that time. I've just sent you an email, tell me if you didn't receive it!

picnixz
picnixz reviewed Jul 17, 2024
View reviewed changes
Comment threadPython/compile.c
iritkatriel
iritkatriel approved these changes Jul 21, 2024
View reviewed changes

@iritkatrieliritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good change.

Comment threadLib/test/test_builtin.py Outdated
Comment threadPython/symtable.c Outdated
picnixz
picnixz reviewed Jul 22, 2024
View reviewed changes
Comment threadPython/compile.c
iritkatriel
iritkatriel reviewed Jul 22, 2024
View reviewed changes
Comment threadLib/test/test_builtin.py Outdated
@JelleZijlstra
JelleZijlstra merged commit 2762c6c into python:mainJul 22, 2024
@JelleZijlstra
JelleZijlstra deleted the toplevelawait branch July 22, 2024 21:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes
@picnixzpicnixzpicnixz left review comments
@carljmcarljmAwaiting requested review from carljmcarljm is a code owner
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JelleZijlstra@picnixz@iritkatriel