Skip to content

gh-119698: fix a special case in symtable.Class.get_methods - #121802

Merged
JelleZijlstra merged 10 commits into
python:mainfrom
picnixz:fix-get-methods-again
Jul 17, 2024
Merged

gh-119698: fix a special case in symtable.Class.get_methods#121802
JelleZijlstra merged 10 commits into
python:mainfrom
picnixz:fix-get-methods-again

Conversation

@picnixz

@picnixzpicnixz commented Jul 15, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

cc @JelleZijlstra@serhiy-storchaka

So, this is the fix of the fix for the following bug: #119698 (comment)

While this fixes what I did, I'm less and less convinced about keeping the method as well...

It is pretty complex now, with complex tests and documentation, and I am not even sure that it is correct. It has high maintenance cost, and its usefulness is questionable.

Well.. it indeed becomes more and more complex =/ the tests are not really complex but we need a lot of them just to be sure that we cover the cases. Maintenance cost is not that much for me, unless the symtable changes. However, I agree that usefulness is questionable... (still didn't manage to find concrete use cases =/)

@bedevere-appbedevere-appBot mentioned this pull request Jul 15, 2024
Closed
@picnixz
picnixz marked this pull request as ready for review July 15, 2024 17:20
JelleZijlstra
JelleZijlstra reviewed Jul 15, 2024
View reviewed changes

@JelleZijlstraJelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, deprecating this may be the right call after all.

Comment threadLib/test/test_symtable.py Outdated
@picnixz

picnixz commented Jul 16, 2024

Copy link
Copy Markdown
MemberAuthor

So, I deprecated the method but kept the fix (I can also revert all the fixes and just mark it as deprecated, but I think it's better to keep something that is working even though we are deprecating it)

JelleZijlstra
JelleZijlstra reviewed Jul 16, 2024
View reviewed changes
Comment threadDoc/library/symtable.rst Outdated
serhiy-storchaka
serhiy-storchaka reviewed Jul 17, 2024
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to split this PR on two. The genexpr fix should be backported to 3.13 and 3.12. The deprecation should only be applied to 3.14.

@picnixz

picnixz commented Jul 17, 2024

Copy link
Copy Markdown
MemberAuthor

I forgot that we backported the original fix... Thanks Serhiy, it should definitely be split into two!

@picnixzpicnixz mentioned this pull request Jul 17, 2024
Merged
@picnixz

picnixz commented Jul 17, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

(FTR, the last commit is just about reverting some RST content that will be included in the next PR (Serhiy approved the changes at the same time I pushed the commit))

@picnixzpicnixz added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 17, 2024
@JelleZijlstra
JelleZijlstra merged commit 6682d91 into python:mainJul 17, 2024
@miss-islington-app

miss-islington-appBot commented Jul 17, 2024

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2024
@picnixz@miss-islington
pythongh-119698: fix a special case insymtable.Class.get_methods(p…
2205149
…ythonGH-121802)
(cherry picked from commit 6682d91)
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2024
@picnixz@miss-islington
pythongh-119698: fix a special case insymtable.Class.get_methods(p…
0febef0
…ythonGH-121802)
(cherry picked from commit 6682d91)
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Jul 17, 2024

Copy link
Copy Markdown

GH-121909 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jul 17, 2024
@bedevere-app

bedevere-appBot commented Jul 17, 2024

Copy link
Copy Markdown

GH-121910 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Jul 17, 2024
JelleZijlstra pushed a commit that referenced this pull request Jul 17, 2024
@miss-islington@picnixz
[3.13]gh-119698: fix a special case insymtable.Class.get_methods(G…
c6ef5ac
…H-121802) (#121909)
(cherry picked from commit 6682d91)
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz
picnixz deleted the fix-get-methods-again branch July 17, 2024 14:10
JelleZijlstra pushed a commit that referenced this pull request Jul 17, 2024
@miss-islington@picnixz
[3.12]gh-119698: fix a special case insymtable.Class.get_methods(G…
3279a4f
…H-121802) (#121910)
(cherry picked from commit 6682d91)
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments
@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz@JelleZijlstra@serhiy-storchaka