Skip to content

gh-121905: Consistently use "floating-point" instead of "floating point" - #121907

Merged
serhiy-storchaka merged 8 commits into
python:mainfrom
serhiy-storchaka:docs-floating-point
Jul 19, 2024
Merged

gh-121905: Consistently use "floating-point" instead of "floating point"#121907
serhiy-storchaka merged 8 commits into
python:mainfrom
serhiy-storchaka:docs-floating-point

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Jul 17, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchakaserhiy-storchaka added docs Documentation in the Doc dir skip news labels Jul 17, 2024
@bedevere-appbedevere-appBot mentioned this pull request Jul 17, 2024
Closed
@serhiy-storchaka

serhiy-storchaka commented Jul 17, 2024

Copy link
Copy Markdown
MemberAuthor

I tried to only use "floating-point" for adjectives, like "floating-point number" and "floating-point arithmetic", not for nouns, like "binary floating point" and "decimal floating point", and not change book names, but it needs third party verification. Maybe there are other cases in which the hyphen is not desirable.

@erlend-aaslanderlend-aasland mentioned this pull request Jul 17, 2024
Merged
@AlexWaygood

AlexWaygood commented Jul 17, 2024

Copy link
Copy Markdown
Member

I tried to only use "floating-point" for adjectives, like "floating-point number" and "floating-point arithmetic", not for nouns, like "binary floating point" and "decimal floating point", and not change book names, but it needs third party verification. Maybe there are other cases in which the hyphen is not desirable.

This is the correct distinction; your choices all look correct to me

AA-Turner
AA-Turner approved these changes Jul 17, 2024
View reviewed changes

@AA-TurnerAA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a brief look through everything and can't spot any obvious problems. I agree re using the hyphenated form.

A

Comment threadDoc/c-api/float.rst
Comment threadDoc/faq/programming.rst Outdated
Comment threadDoc/reference/datamodel.rst
Comment threadDoc/tutorial/floatingpoint.rst
@rhettinger
rhettinger removed their request for review July 18, 2024 01:45
mdickinson
mdickinson approved these changes Jul 18, 2024
View reviewed changes

@mdickinsonmdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed line-by-line, but the change LGTM in principle.

@serhiy-storchakaserhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 18, 2024
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) July 19, 2024 07:42
@serhiy-storchaka
serhiy-storchaka merged commit 1a0c7b9 into python:mainJul 19, 2024
@miss-islington-app

miss-islington-appBot commented Jul 19, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Jul 19, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1a0c7b9ba48a2dffb70bb0c7327abae1d3e87356 3.13

@miss-islington-app

miss-islington-appBot commented Jul 19, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1a0c7b9ba48a2dffb70bb0c7327abae1d3e87356 3.12

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 19, 2024
@serhiy-storchaka
[3.13]pythongh-121905: Consistently use "floating-point" instead of …
d513ade
…"floating point" (pythonGH-121907)
(cherry picked from commit 1a0c7b9)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-appBot commented Jul 19, 2024

Copy link
Copy Markdown

GH-122012 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 19, 2024
@serhiy-storchaka
pythongh-121905: Consistently use "floating-point" instead of "floati…
31868ad
…ng point" (pythonGH-121907)
(cherry picked from commit 1a0c7b9)
@bedevere-app

bedevere-appBot commented Jul 19, 2024

Copy link
Copy Markdown

GH-122013 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Jul 19, 2024
serhiy-storchaka added a commit that referenced this pull request Jul 19, 2024
@serhiy-storchaka
[3.12]gh-121905: Consistently use "floating-point" instead of "float…
39dea21
…ing point" (GH-121907) (GH-122013)
(cherry picked from commit 1a0c7b9)
serhiy-storchaka added a commit that referenced this pull request Jul 19, 2024
@serhiy-storchaka
[3.13]gh-121905: Consistently use "floating-point" instead of "float…
a45d905
…ing point" (GH-121907) (GH-122012)
(cherry picked from commit 1a0c7b9)
@serhiy-storchaka
serhiy-storchaka deleted the docs-floating-point branch July 19, 2024 13:10
@serhiy-storchakaserhiy-storchaka removed their assignment Jul 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAA-Turner approved these changes
@ezio-melottiezio-melottiezio-melotti left review comments
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes
@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner
@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner
@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner
@abalkinabalkinAwaiting requested review from abalkin
@iritkatrieliritkatrielAwaiting requested review from iritkatrieliritkatriel is a code owner
@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner
@corona10corona10Awaiting requested review from corona10corona10 is a code owner
+1 more reviewer
@mdickinsonmdickinsonmdickinson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka@AlexWaygood@mdickinson@AA-Turner@ezio-melotti