Skip to content

GH-120024: Add verification tool to check for unmarked escaping calls - #121917

Closed
markshannon wants to merge 3 commits into
python:mainfrom
faster-cpython:check-for-escapes
Closed

GH-120024: Add verification tool to check for unmarked escaping calls#121917
markshannon wants to merge 3 commits into
python:mainfrom
faster-cpython:check-for-escapes

Conversation

@markshannon

@markshannonmarkshannon commented Jul 17, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Add tool to check for unmarked escaping calls.
Output looks like:

Unmarked escaping function '_Py_Instrument' at .../bytecodes.c:159
Unmarked escaping function '_Py_Instrument' at .../bytecodes.c:194
Unmarked escaping function '_Py_call_instrumentation' at .../bytecodes.c:204
Unmarked escaping function '_PyFrame_GetStackPointer' at .../bytecodes.c:206
Unmarked escaping function '_PyEval_FormatExcCheckArg' at .../bytecodes.c:223
...

Currently there are about 250 escaping calls in bytecodes.c
We will eventually turn this on in CI, once we've marked all the escaping calls.

@bedevere-appbedevere-appBot mentioned this pull request Jul 17, 2024
Open
@markshannon
markshannon deleted the check-for-escapes branch August 6, 2024 10:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

awaiting core reviewskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@markshannon