Uh oh!
There was an error while loading. Please reload this page.
gh-121621: Move asyncio_running_loop to private struct - #121939
Conversation
This avoids changing the ABI and keeps the field in the private struct.
colesbury
commented
Jul 17, 2024
I don't know if we care enough about avoiding ABI changes in 3.13. If not, then feel free to close this PR. |
JelleZijlstra
commented
Jul 17, 2024
I don't know much about this area, but it seems better in any case to put this element on a private struct if we don't need it to be public. |
Yhg1s
commented
Jul 17, 2024
Considering ABI stability is of great benefit for testing, and this doesn't seem like an otherwise onerous change, I'd prefer to get this in. We need to delay 3.13b4 until tomorrow anyway because of unrelated issues, so I'll respin with this in. |
Thanks @colesbury for the PR, and @Yhg1s for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
GH-121943 is a backport of this pull request to the 3.13 branch. |
bedevere-bot
commented
Jul 18, 2024
|
This avoids changing the ABI and places the field in the private struct.