Skip to content

gh-112301: -fstack-protector-strong is also needed in LDFLAGS on Solaris/Illumos - #121979

Closed
kulikjak wants to merge 3 commits into
python:mainfrom
kulikjak:Solaris-fstack-protector-fix
Closed

gh-112301: -fstack-protector-strong is also needed in LDFLAGS on Solaris/Illumos#121979
kulikjak wants to merge 3 commits into
python:mainfrom
kulikjak:Solaris-fstack-protector-fix

Conversation

@kulikjak

@kulikjakkulikjak commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

Linker on Solaris/Illumos is unhappy when you pass -fstack-protector-strong flag via CFLAGS but not LDFLAGS, resulting in the following failure after #120975:

Undefined first referenced
symbol in file
__stack_chk_fail Programs/_freeze_module.o
__stack_chk_guard Programs/_freeze_module.o
ld: fatal: symbol referencing errors

I don't think that other links will mind, but I can certainly make this into a Solaris/Illumos specific LDFLAGS append.

@corona10

Copy link
Copy Markdown
Member

see: #121996 (comment)

@kulikjak
kulikjakforce-pushed the Solaris-fstack-protector-fix branch from 5673fe7 to cd9638aCompareJuly 30, 2024 13:05
@vstinner

Copy link
Copy Markdown
Member

I close this PR since it's inactive since July 2024: #112301 (comment). If you are still hitting the issue, I suggest opening a new PR. By the way, I'm not sure that modifying LDFLAGS is correct. Modifying LDFLAGS_NODIST sounds safer.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kulikjak@corona10@vstinner@erlend-aasland