gh-112301: Add macOS warning tracking tooling by nohlson · Pull Request #122211 · python/cpython

nohlson · 2024-07-24T05:17:03Z

Implement warning tracking for macOS GitHub Actions builds.

This tooling builds on #121730

check_warnings.py now takes an argument to parse compiler output of two types:

json from gcc using -fdiagnostic-format=json
generic clang compiler warning output

The macOS build and test job configuration is modified to write compiler output to a file and run the check_warnings.py tool.

Issue: Consider applying flags for warnings about potential security issues #112301

hugovk · 2024-07-30T06:44:47Z

This has some conflicts now #121730 has been merged.

nohlson · 2024-07-30T15:29:50Z

This has some conflicts now #121730 has been merged.

I have updated the script to included changes made in #121730

hugovk

Looks good, just some nits :)

nohlson · 2024-08-05T20:02:32Z

I have made the requested changes; please review again

bedevere-app · 2024-08-05T20:02:36Z

Thanks for making the requested changes!

: please review the changes made to this pull request.

hugovk

Thanks!

(The failing Hypothesis CI check is unrelated, and already fixed in main, we can ignore it here.)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

nohlsonand others added 26 commits July 23, 2024 03:14

Create simple warning check tool and add to ubuntu build and test job
5148727

Add flags to check warnings script to fail on regression or improvement
3bd5a10

Remove redundant comment
6813003

Rename warnigore file to warningignore
ab4d754

Use regex to extract json arrays
615d228

Trim whitespace
fc0a60b

Test on github unexpected improvement
7793d80

Add config for improve fail check
99715d2

Revert to prod check warning state
bc44ec2

📜🤖 Added by blurb_it.
e2ca75f

Refactor creating set of files with warnings to a dedicated function
bd1634e

Move cflags configure option to top level build configuration
b07b1d6

Add json diagnostics to ubuntu configuration as first argument
e1954a5

Add newline to news
5935143

Create simple warning check tool and add to ubuntu build and test job
7f1a238

Add macos warning checks to GitHub actions
144136e

Revert reusable-macos.yml for environment variables
3dd40fd

Update paths
1158f53

Test unexpected improvement
cb51b4f

Remove warning ignore
77e0f6e

Add json output option to macos configure job
3e1d75f

Add common dictionary format when parsing warnings
b5cd58a

Remove configure option for macos job
02f313e

Print out json version of compiler output
83d1ed7

Remove old version of warning ignore file
08a6f6d

Remove compiler output print diagnostic
7be8ee6

nohlson requested review from ezio-melotti and hugovk as code owners July 24, 2024 05:17

bedevere-appBot mentioned this pull request Jul 24, 2024
Consider applying flags for warnings about potential security issues #112301
Closed

bedevere-appBot added the awaiting review label Jul 24, 2024

hugovk removed request for asvetlov, gvanrossum and willingc July 26, 2024 06:36

hugovk changed the title ~~gh-112301: Add macos warning tracking tooling~~gh-112301: Add macOS warning tracking toolingJul 30, 2024

nohlson added 2 commits July 30, 2024 10:23

oMerge branch 'main' into add-macos-warnings-tracking-tooling
522f27c

Add period to news
b654a84

nohlson mentioned this pull request Jul 30, 2024
gh-112301: Add argument aliases and tee compiler output for check warnings #122465
Merged

nohlson added 2 commits July 30, 2024 22:19

Merge branch 'main' into add-macos-warnings-tracking-tooling
7780da6

Make warning ignore file optional
3688c5c

nohlson commented Jul 31, 2024
View reviewed changes

Comment threadTools/build/check_warnings.py Outdated

Add write compiler output to log and file
cb1f276

hugovk reviewed Jul 31, 2024
View reviewed changes

Fix formatting and update regex
fb91e3e

hugovk reviewed Jul 31, 2024
View reviewed changes

Fix comment formatting
f35ba60

bedevere-appBot added awaiting change review and removed awaiting review labels Aug 5, 2024

nohlson mentioned this pull request Aug 6, 2024
gh-112301: Add Warning Count to Warning Check Tooling #122711
Merged

hugovk approved these changes Aug 6, 2024
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting change review labels Aug 6, 2024

hugovk merged commit 58be1c2 into python:mainAug 6, 2024

bedevere-appBot removed the awaiting merge label Aug 6, 2024

nohlson mentioned this pull request Aug 7, 2024
Add compiler warning tracking tooling failure remediation guidance python/devguide#1364
Merged

brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
pythongh-112301: Add macOS warning tracking tooling (python#122211)
1106378
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
pythongh-112301: Add macOS warning tracking tooling (python#122211)
d29a061
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

Uh oh!

Uh oh!

Conversation

nohlson commented Jul 24, 2024• edited by bedevere-app BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hugovk commented Jul 30, 2024

Uh oh!

nohlson commented Jul 30, 2024

Uh oh!

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nohlson commented Aug 5, 2024

Uh oh!

bedevere-appBot commented Aug 5, 2024

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nohlson commented Jul 24, 2024•
edited by bedevere-app Bot
Loading