Skip to content

gh-122361: Use proper PyUnicodeWriter_* API in constevaluator_call - #122362

Merged
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-122361
Jul 27, 2024
Merged

gh-122361: Use proper PyUnicodeWriter_* API in constevaluator_call#122362
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-122361

Conversation

@sobolevn

@sobolevnsobolevn commented Jul 27, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Jul 27, 2024
Closed
@sobolevnsobolevn mentioned this pull request Jul 27, 2024
Merged
picnixz
picnixz reviewed Jul 27, 2024
View reviewed changes

@picnixzpicnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much is the overhead of using the public API instead of the (slightly, or perhaps more) faster private API?

Comment threadObjects/typevarobject.c Outdated
Comment threadObjects/typevarobject.c Outdated
JelleZijlstra
JelleZijlstra approved these changes Jul 27, 2024
View reviewed changes

@JelleZijlstraJelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, thought I got all the warnings.

@sobolevn
sobolevn merged commit 04eb5c8 into python:mainJul 27, 2024
@sobolevn

sobolevn commented Jul 27, 2024

Copy link
Copy Markdown
MemberAuthor

How much is the overhead of using the public API instead of the (slightly, or perhaps more) faster private API?

Oups, sorry, @picnixz, I missed this question!
I don't really think that it really matters in this use-case :)

@picnixz

picnixz commented Jul 27, 2024

Copy link
Copy Markdown
Member

No worry (I also don't think it matters (I didn't know in which context it was being used actually))

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments
@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@markshannonmarkshannonAwaiting requested review from markshannon

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn@picnixz@JelleZijlstra