Skip to content

gh-119180: annotationlib: Fix __all__, other minor fixes - #122365

Merged
JelleZijlstra merged 3 commits into
python:mainfrom
JelleZijlstra:pep649-cleanup
Aug 11, 2024
Merged

gh-119180: annotationlib: Fix __all__, other minor fixes#122365
JelleZijlstra merged 3 commits into
python:mainfrom
JelleZijlstra:pep649-cleanup

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented Jul 27, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Jul 27, 2024
Closed
30 tasks
JelleZijlstra
JelleZijlstra commented Jul 27, 2024
View reviewed changes
Comment threadLib/annotationlib.py
Comment on lines +13 to +14
"call_evaluate_function",
"get_annotate_function",

@JelleZijlstraJelleZijlstraJul 27, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two were missing. The rest of the changes in this file are just formatting.

Comment threadLib/test/test_annotationlib.py
self.assertIs(annotate_func, None)


class TestAnnotationLib(unittest.TestCase):

@JelleZijlstraJelleZijlstraJul 27, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only non-formatting change in this file.

@JelleZijlstraJelleZijlstra changed the title gh-119180: annotationlib: Fix __all__, reformat, other minor fixesgh-119180: annotationlib: Fix __all__, run Black on annotationlib.py, other minor fixesJul 27, 2024
AA-Turner
AA-Turner reviewed Jul 27, 2024
View reviewed changes

@AA-TurnerAA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first stdlib module we're proposing to use autoformatting for, is it worth checking on Discourse? Autoformatters are much more opionated than PEP 8, which may be a surprising experience for contributors (note @encukou ran into an issue with a similar tool just whilst making a change to a CPython-only docs extension).

A

@JelleZijlstra

JelleZijlstra commented Jul 27, 2024

Copy link
Copy Markdown
MemberAuthor

I hoped it wouldn't be controversial since we're already doing it for some of the Tools/ code. I'm not interested in discussing this issue on Discourse; if there's disagreement, I'll just take out the autoformatting.

@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) August 11, 2024 23:21
@JelleZijlstra
JelleZijlstra merged commit 4534068 into python:mainAug 11, 2024
@hugovkhugovk changed the title gh-119180: annotationlib: Fix __all__, run Black on annotationlib.py, other minor fixesgh-119180: annotationlib: Fix __all__, run Black other minor fixesAug 12, 2024
@hugovkhugovk changed the title gh-119180: annotationlib: Fix __all__, run Black other minor fixesgh-119180: annotationlib: Fix __all__, other minor fixesAug 12, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@JelleZijlstra@blhsing
pythongh-119180: annotationlib: Fix __all__, formatting (python#122365)
ace7ab9
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAA-Turner left review comments
@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygood
@hugovkhugovkAwaiting requested review from hugovk

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JelleZijlstra@AA-Turner