Skip to content

gh-122237: Fix repl auto indentation wrong with comments - #122383

Closed
AnsonTrapani wants to merge 5 commits into
python:mainfrom
AnsonTrapani:fix-repl-auto-indentation-wrong-with-comments
Closed

gh-122237: Fix repl auto indentation wrong with comments#122383
AnsonTrapani wants to merge 5 commits into
python:mainfrom
AnsonTrapani:fix-repl-auto-indentation-wrong-with-comments

Conversation

@AnsonTrapani

@AnsonTrapaniAnsonTrapani commented Jul 29, 2024

Copy link
Copy Markdown

@ghost

ghost commented Jul 29, 2024

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Eclips4Eclips4 changed the title Fix repl auto indentation wrong with comments: gh-122237gh-122237: Fix repl auto indentation wrong with commentsJul 29, 2024
@bedevere-app

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@devdanzin

Copy link
Copy Markdown
Member

There's also a proposed fix in #122238.

@AnsonTrapani

Copy link
Copy Markdown
Author

There's also a proposed fix in #122238.

Hi devdanzin,

Does that one get the priority then or is this merge request going to be closed without a merge? Sorry, this is my first time contributing here so I'm not sure of the procedure!

Thank you!

@terryjreedy

Copy link
Copy Markdown
Member

If two PRs have different solutions, 'priority' is not an issue. (I have not looked at either.) A core dev needs to decide which is superior and merge that, possibly after further changes. Reviewers can test both and give opinions.

@ambv

ambv commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

Fixed in GH-123196.

@ambvambv closed this Oct 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@AnsonTrapani@devdanzin@terryjreedy@ambv