Skip to content

bpo-35967 resolve platform.processor late - #12239

Merged
jaraco merged 18 commits into
python:masterfrom
jaraco:feature/35967-platform-processor-resolved-late
Apr 16, 2020
Merged

bpo-35967 resolve platform.processor late#12239
jaraco merged 18 commits into
python:masterfrom
jaraco:feature/35967-platform-processor-resolved-late

Conversation

@jaraco

@jaracojaraco commented Mar 8, 2019

Copy link
Copy Markdown
Member

@jaraco

Copy link
Copy Markdown
MemberAuthor

I see the appveyor tests failed, but I'm going to assume that's a spurious failure, since it doesn't happen on the Azure pipelines and doesn't seem to be relevant to the test_platform tests.

@csabella
csabella requested a review from malemburgJune 1, 2019 15:15
@gpshead

gpshead commented Sep 12, 2019

Copy link
Copy Markdown
Member

reopening to retrigger CI. (we removed appveyor recently)

@gpsheadgpshead closed this Sep 12, 2019
@gpsheadgpshead reopened this Sep 12, 2019
@jaraco

Copy link
Copy Markdown
MemberAuthor

In the aforementioned issue, Marc agreed this approach is suitable as long as it has tests, which it does. Is anything more needed?

@jaracojaraco added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2020
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @jaraco for commit f0daf49 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2020
… had any effect). Rely on _unknown_as_blank to replace unknown with blank.
@jaraco
jaraco removed the request for review from malemburgApril 16, 2020 00:39
@jaracojaraco added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2020
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @jaraco for commit d57e3ab 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2020
@jaraco

Copy link
Copy Markdown
MemberAuthor

Failed checks look unrelated.

@jaracojaraco closed this Apr 16, 2020
@jaracojaraco reopened this Apr 16, 2020
@jaraco
jaraco merged commit 518835f into python:masterApr 16, 2020
@jaraco
jaraco deleted the feature/35967-platform-processor-resolved-late branch April 16, 2020 12:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jaraco@gpshead@bedevere-bot@the-knights-who-say-ni