Skip to content

gh-122404: Fix reference leak in sum implementation - #122405

Closed
Eclips4 wants to merge 1 commit into
python:mainfrom
Eclips4:issue-122404
Closed

gh-122404: Fix reference leak in sum implementation#122405
Eclips4 wants to merge 1 commit into
python:mainfrom
Eclips4:issue-122404

Conversation

@Eclips4

@Eclips4Eclips4 commented Jul 29, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Jul 29, 2024
Closed
@Eclips4
Eclips4 requested a review from vstinnerJuly 29, 2024 15:30
@Eclips4

Eclips4 commented Jul 29, 2024

Copy link
Copy Markdown
MemberAuthor

cc @skirpichev

@Eclips4

Eclips4 commented Jul 29, 2024

Copy link
Copy Markdown
MemberAuthor

With this fix applied, test_builtin no longer leaks references:

eclips4@HOME-PC~/p/cpython (issue-122404)> ./python-mtest-R3:3test_builtinUsingrandomseed: 35259550140:00:00loadavg: 33.00Run1testsequentiallyinasingleprocess0:00:00loadavg: 33.00 [1/1] test_builtinbeginning6repetitions. Showingnumberofleaks (. for0orless, Xfor10ormore)
123:456XX. ...
==Testsresult: SUCCESS==1testOK.
Totalduration: 11.8secTotaltests: run=135skipped=5Totaltestfiles: run=1/1Result: SUCCESS

@ericsnowcurrently
ericsnowcurrently removed their request for review July 29, 2024 15:43
@Eclips4Eclips4 mentioned this pull request Jul 29, 2024
Closed
@encukouencukou mentioned this pull request Jul 29, 2024
Merged
@Eclips4

Eclips4 commented Jul 29, 2024

Copy link
Copy Markdown
MemberAuthor

Closing per #122234 (comment)

@Eclips4Eclips4 closed this Jul 29, 2024
@Eclips4
Eclips4 deleted the issue-122404 branch July 29, 2024 15:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

awaiting reviewskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Eclips4