Skip to content

gh-118943: Remove 'regen-jit' from the 'regen-all' make target - #122602

Merged
brandtbucher merged 6 commits into
python:mainfrom
hroncok:regen-jit-noall
Aug 8, 2024
Merged

gh-118943: Remove 'regen-jit' from the 'regen-all' make target#122602
brandtbucher merged 6 commits into
python:mainfrom
hroncok:regen-jit-noall

Conversation

@hroncok

@hroncokhroncok commented Aug 2, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Aug 2, 2024
Closed
@hroncokhroncok mentioned this pull request Aug 2, 2024
Merged
@Eclips4Eclips4 added the needs backport to 3.13 bugs and security fixes label Aug 2, 2024
@erlend-aasland

erlend-aasland commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

Workflow nit: instead of opening a PR against a closed issue, please either re-open the existing issue, or create a new one.

@erlend-aasland

erlend-aasland commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

For the record, see #120690 (review) for why this PR was made.

erlend-aasland
erlend-aasland requested changes Aug 2, 2024
View reviewed changes
Comment thread.github/workflows/build.yml Outdated
@bedevere-app

bedevere-appBot commented Aug 2, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

merwok
merwok reviewed Aug 2, 2024
View reviewed changes
Comment threadMakefile.pre.in Outdated
hroncokand others added 2 commits August 3, 2024 09:57
@hroncok

hroncok commented Aug 3, 2024

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again

@bedevere-app

bedevere-appBot commented Aug 3, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

@hroncok

hroncok commented Aug 5, 2024

Copy link
Copy Markdown
ContributorAuthor

The aarch64 CI failures seem unrelated to this PR.

brandtbucher
brandtbucher requested changes Aug 5, 2024
View reviewed changes

@brandtbucherbrandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we literally just need to remove regen-jit from regen-all, nothing more. :)

Comment thread.github/workflows/jit.yml
Comment threadMakefile.pre.in Outdated
Comment threadMisc/NEWS.d/next/Build/2024-08-02-12-59-15.gh-issue-118943.vZQtET.rst Outdated
@bedevere-app

bedevere-appBot commented Aug 5, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@brandtbucherbrandtbucher self-assigned this Aug 5, 2024
@brandtbucherbrandtbucher added build The build process and cross-build topic-JIT labels Aug 5, 2024
brandtbucher
brandtbucher approved these changes Aug 5, 2024
View reviewed changes

@brandtbucherbrandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hroncok

hroncok commented Aug 5, 2024

Copy link
Copy Markdown
ContributorAuthor

I misunderstood the problem at first. I assumed calling make regen-jit was still necessary.

However, I now see that the jit_stencils.h target calls the same command, which probably explains why it was called parallelly.

@brandtbucher
brandtbucher merged commit 8c9d174 into python:mainAug 8, 2024
@miss-islington-app

miss-islington-appBot commented Aug 8, 2024

Copy link
Copy Markdown

Thanks @hroncok for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2024
@hroncok@merwok@miss-islington
pythonGH-118943: Remove regen-jit from the regen-all make target (pyt…
0d5ed2e
…honGH-122602)
(cherry picked from commit 8c9d174)
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
Co-authored-by: Éric <merwok@netwok.org>
@bedevere-app

bedevere-appBot commented Aug 8, 2024

Copy link
Copy Markdown

GH-122840 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Aug 8, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@hroncok@merwok@blhsing
pythonGH-118943: Remove regen-jit from the regen-all make target (pyt…
701a1d7
…honGH-122602)
Co-authored-by: Éric <merwok@netwok.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwokmerwokmerwok left review comments
@brandtbucherbrandtbucherbrandtbucher approved these changes
@Eclips4Eclips4Eclips4 approved these changes
@ezio-melottiezio-melottiAwaiting requested review from ezio-melotti
@hugovkhugovkAwaiting requested review from hugovk
@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees

@brandtbucherbrandtbucher

Labels

buildThe build process and cross-buildtopic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hroncok@erlend-aasland@merwok@brandtbucher@Eclips4