Skip to content

gh-118814: Fix the TypeVar constructor when name is passed by keyword - #122664

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:TypeVar-constructor
Aug 7, 2024
Merged

gh-118814: Fix the TypeVar constructor when name is passed by keyword#122664
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:TypeVar-constructor

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Aug 4, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Fix _PyArg_UnpackKeywordsWithVararg for the case when argument for positional-or-keyword parameter is passed by keyword. There was only one such case in the stdlib -- the TypeVar constructor.

@serhiy-storchaka
pythongh-118814: Fix the TypeVar constructor when name is passed by k…
dc5949e
…eyword
Fix _PyArg_UnpackKeywordsWithVararg for the case when argument for
positional-or-keyword parameter is passed by keyword.
There was only one such case in the stdlib -- the TypeVar constructor.
@serhiy-storchakaserhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Aug 4, 2024
@bedevere-appbedevere-appBot mentioned this pull request Aug 4, 2024
Closed
@serhiy-storchakaserhiy-storchaka mentioned this pull request Aug 4, 2024
Closed
@picnixz

picnixz commented Aug 4, 2024

Copy link
Copy Markdown
Member

I think I also tried that approach but got a segfault with the example I showed. Could you check whether I may have missed something (or did something incorrect?):

vararg_with_many_argsa: objectb: objectc: objectd: object*args: objecte: boolf: bool=Falseg: bool=False

and test:

  • Calling ac_tester.vararg_with_many_args(1, 2, 3, 4, e=5)
  • Calling ac_tester.vararg_with_many_args(1, 2, 3, 4, e=5, f=6)

@serhiy-storchaka

serhiy-storchaka commented Aug 4, 2024

Copy link
Copy Markdown
MemberAuthor

Oh, yes. There are several more bugs in Argument Clinic.

@serhiy-storchaka

serhiy-storchaka commented Aug 5, 2024

Copy link
Copy Markdown
MemberAuthor

But they are only Argument Clinic bugs and not related to this issue.

@serhiy-storchaka
serhiy-storchaka merged commit 540fcc6 into python:mainAug 7, 2024
@miss-islington-app

miss-islington-appBot commented Aug 7, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchaka
serhiy-storchaka deleted the TypeVar-constructor branch August 7, 2024 20:30
@miss-islington-app

miss-islington-appBot commented Aug 7, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 540fcc62f5da982b79504221cac01bfab8b73ba1 3.13

@miss-islington-app

miss-islington-appBot commented Aug 7, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 540fcc62f5da982b79504221cac01bfab8b73ba1 3.12

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 7, 2024
@serhiy-storchaka
[3.13]pythongh-118814: Fix the TypeVar constructor when name is pass…
5d0a55d
…ed by keyword (pythonGH-122664)
Fix _PyArg_UnpackKeywordsWithVararg for the case when argument for
positional-or-keyword parameter is passed by keyword.
There was only one such case in the stdlib -- the TypeVar constructor.
(cherry picked from commit 540fcc6)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-appBot commented Aug 7, 2024

Copy link
Copy Markdown

GH-122806 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Aug 7, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 7, 2024
@serhiy-storchaka
[3.12]pythongh-118814: Fix the TypeVar constructor when name is pass…
87c6e9d
…ed by keyword (pythonGH-122664)
Fix _PyArg_UnpackKeywordsWithVararg for the case when argument for
positional-or-keyword parameter is passed by keyword.
There was only one such case in the stdlib -- the TypeVar constructor.
(cherry picked from commit 540fcc6)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-appBot commented Aug 7, 2024

Copy link
Copy Markdown

GH-122807 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Aug 7, 2024
@serhiy-storchakaserhiy-storchaka removed their assignment Aug 7, 2024
erlend-aasland
erlend-aasland reviewed Aug 7, 2024
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

serhiy-storchaka added a commit that referenced this pull request Aug 8, 2024
@serhiy-storchaka
[3.13]gh-118814: Fix the TypeVar constructor when name is passed by …
1fd1c6c
…keyword (GH-122664) (GH-122806)
Fix _PyArg_UnpackKeywordsWithVararg for the case when argument for
positional-or-keyword parameter is passed by keyword.
There was only one such case in the stdlib -- the TypeVar constructor.
(cherry picked from commit 540fcc6)
serhiy-storchaka added a commit that referenced this pull request Aug 8, 2024
@serhiy-storchaka
[3.12]gh-118814: Fix the TypeVar constructor when name is passed by …
f2cc8ad
…keyword (GH-122664) (GH-122807)
Fix _PyArg_UnpackKeywordsWithVararg for the case when argument for
positional-or-keyword parameter is passed by keyword.
There was only one such case in the stdlib -- the TypeVar constructor.
(cherry picked from commit 540fcc6)
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@serhiy-storchaka@blhsing
pythongh-118814: Fix the TypeVar constructor when name is passed by k…
5890a6c
…eyword (pythonGH-122664)
Fix _PyArg_UnpackKeywordsWithVararg for the case when argument for
positional-or-keyword parameter is passed by keyword.
There was only one such case in the stdlib -- the TypeVar constructor.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland left review comments
@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstraJelleZijlstra is a code owner
@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygoodAlexWaygood is a code owner

Assignees

No one assigned

Labels

type-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka@picnixz@erlend-aasland