Skip to content

gh-122686: pin attrs package (for hypothesis workflow) - #122687

Merged
hugovk merged 3 commits into
python:mainfrom
skirpichev:pin-attrs-122686
Aug 6, 2024
Merged

gh-122686: pin attrs package (for hypothesis workflow)#122687
hugovk merged 3 commits into
python:mainfrom
skirpichev:pin-attrs-122686

Conversation

@skirpichev

@skirpichevskirpichev commented Aug 5, 2024

Copy link
Copy Markdown
Member

@hugovk

Copy link
Copy Markdown
Member

Do we still need to pin if upgrading to latest hypothesis==6.108.8?

If so, please can you add a comment as to why we're adding an attrs pin?

@skirpichev

Copy link
Copy Markdown
MemberAuthor

Do we still need to pin if upgrading to latest hypothesis==6.108.8?

Yes, I think so. See:
https://github.com/python/cpython/actions/runs/10246311678/job/28343157458

If so, please can you add a comment as to why we're adding an attrs pin?

I did no debugging, but new release seems broken on the CPython main. Pinning "just works", e.g. (see last commit):
#122682

I'll open issue for attrs and add a comment with reference.

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadTools/requirements-hypothesis.txt Outdated
Co-authored-by: Victor Stinner <vstinner@python.org>
@hugovk
hugovk merged commit 35ae4aa into python:mainAug 6, 2024
@skirpichev
skirpichev deleted the pin-attrs-122686 branch August 6, 2024 03:58
@hugovk

Copy link
Copy Markdown
Member

Thanks!

brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@skirpichev@hugovk@vstinner