Skip to content

gh-121268: remove workarounds for non-IEEE 754 systems in cmath - #122716

Merged
vstinner merged 2 commits into
python:mainfrom
skirpichev:drop-cmath-legacy-121268
Aug 9, 2024
Merged

gh-121268: remove workarounds for non-IEEE 754 systems in cmath#122716
vstinner merged 2 commits into
python:mainfrom
skirpichev:drop-cmath-legacy-121268

Conversation

@skirpichev

@skirpichevskirpichev commented Aug 6, 2024

Copy link
Copy Markdown
Member

as now building Python now requires support of IEEE 754 floating point numbers.

as now building Python now requires support of IEEE 754 floating point
numbers.
@vstinnervstinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 8, 2024
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 470a59d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 8, 2024

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if buildbots are happy with this change.

@skirpichev

Copy link
Copy Markdown
MemberAuthor

No failures, related to this pr.

@vstinner
vstinner merged commit b6e745a into python:mainAug 9, 2024
@vstinner

Copy link
Copy Markdown
Member

Merged, thanks.

@skirpichev
skirpichev deleted the drop-cmath-legacy-121268 branch August 9, 2024 09:26
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.x has failed when building commit b6e745a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1380/builds/1044) and take a look at the build logs.
  4. Check if the failure is related to this commit (b6e745a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1380/builds/1044

Failed tests:

  • test_socketserver

Failed subtests:

  • test_UnixDatagramServer - test.test_socketserver.SocketServerTest.test_UnixDatagramServer

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 222, in test_UnixDatagramServerself.run_server(socketserver.UnixDatagramServer,
~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
socketserver.DatagramRequestHandler,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^self.dgram_examine)
^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/support/threading_helper.py", line 66, in decoratorreturn func(*args)
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 133, in run_server
testfunc(svrcls.address_family, addr)
~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 160, in dgram_examine
buf = data = receive(s, 100)
~~~~~~~^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 43, in receiveraiseRuntimeError("timed out on %r"% (sock,))
RuntimeError: timed out on <socket.socket fd=34, family=1, type=2, proto=0, laddr=./test_python_7aihzq4p.sock>
Traceback (most recent call last):
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/threading.py", line 1041, in _bootstrap_innerself.run()
~~~~~~~~^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/threading.py", line 992, in runself._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 240, in serve_foreverself._handle_request_noblock()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 320, in _handle_request_noblockself.handle_error(request, client_address)
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 318, in _handle_request_noblockself.process_request(request, client_address)
~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 349, in process_requestself.finish_request(request, client_address)
~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 362, in finish_requestself.RequestHandlerClass(request, client_address, self)
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 763, in __init__self.finish()
~~~~~~~~~~~^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 858, in finishself.socket.sendto(self.wfile.getvalue(), self.client_address)
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ConnectionResetError: [Errno 54] Connection reset by peer
ERROR

blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
…python#122716)
As now building Python now requires support of IEEE 754 floating point
numbers.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@skirpichev@bedevere-bot@vstinner