Uh oh!
There was an error while loading. Please reload this page.
GH-122821: Simplify compilation of while statements to ensure consistency of offsets for sys.monitoring - #122934
Merged
Merged
Conversation
…set for sys.monitoring
markshannon
commented
Aug 12, 2024
MemberAuthor
Performance on tier 1 maybe shows a slight (<1%) slowdown (it might be noise). I'm not concerned by any possible tier 1 slowdown, as we are focusing our efforts on tier 2. |
Member
It would be good to add a test in test_monitoring about the branch location issue. |
iritkatriel
approved these changes
Aug 12, 2024
picnixz
reviewed
Aug 12, 2024
Uh oh!
There was an error while loading. Please reload this page.
…e-122821.WnAzTK.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
commented
Aug 13, 2024
Member
@markshannon Wouldn't this need to be backported to 3.13 as well? (or maybe you are creating the backport manually?) |
blhsing pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…onsistency of offsets for sys.monitoring (pythonGH-122934)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whilestatements #122821