Uh oh!
There was an error while loading. Please reload this page.
gh-122965: Fix reusable-change-detection.yml on workflow_dispatch - #122966
Conversation
My manual run: https://github.com/sobolevn/cpython/actions/runs/10366976128 ![]() |
One more point to consider: maybe instead we always need to run docs and windows msi jobs on Basically I propose to think about this change, from: - name: Check for docs changesif: >- github.event_name == 'pull_request' && steps.changed-docs-files.outputs.added_modified_renamed != ''id: docs-changesrun: | echo "run-docs=true" >> "${GITHUB_OUTPUT}"to: - name: Check for docs changesif: >- (github.event_name == 'pull_request' && steps.changed-docs-files.outputs.added_modified_renamed != '') || github.event_name == 'workflow_dispatch'id: docs-changesrun: | echo "run-docs=true" >> "${GITHUB_OUTPUT}"and the same for |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sobolevn
commented
Aug 13, 2024
https://github.com/sobolevn/cpython/actions/runs/10368635188/job/28702683326 ![]() So, I addapted it. |
Uh oh!
There was an error while loading. Please reload this page.
sobolevn
commented
Aug 13, 2024
The last version worked: https://github.com/sobolevn/cpython/actions/runs/10368788774/job/28703154687 |
sobolevn
commented
Aug 13, 2024
Done, @hugovk! Thanks for your quick and helpful review! 👍 |
Uh oh!
There was an error while loading. Please reload this page.
webknjaz
commented
Aug 13, 2024
Looks like the PR title/description needs updating. |
Uh oh!
There was an error while loading. Please reload this page.
sobolevn
commented
Aug 13, 2024
Failures are unrelated, GitHub was down. Re-running. The manual build was succesful: https://github.com/sobolevn/cpython/actions/runs/10370346404/job/28708436891 |
sobolevn
commented
Aug 13, 2024
This looks complete now! GitHub re-run worked, local manual tests passed: https://github.com/sobolevn/cpython/actions/runs/10370346404/job/28708436891 Thanks everyone! |
…patch` (pythonGH-122966) (cherry picked from commit 6ae942f) Co-authored-by: sobolevn <mail@sobolevn.me>
GH-123008 is a backport of this pull request to the 3.13 branch. |
…patch` (pythonGH-122966) (cherry picked from commit 6ae942f) Co-authored-by: sobolevn <mail@sobolevn.me>
GH-123009 is a backport of this pull request to the 3.12 branch. |
hugovk
commented
Aug 14, 2024
After merging, I tested a manual trigger and looks good: https://github.com/python/cpython/actions/runs/10387198512 👍 |


We no longer skip
DocsandWindows MSIjobs onworkflow_triggerbut instead they are now always executed on manual runs.Refs #122336