Skip to content

GH-118093: Specialize CALL_KW - #123006

Merged
markshannon merged 12 commits into
python:mainfrom
faster-cpython:specialize-call-kw
Aug 16, 2024
Merged

GH-118093: Specialize CALL_KW#123006
markshannon merged 12 commits into
python:mainfrom
faster-cpython:specialize-call-kw

Conversation

@markshannon

@markshannonmarkshannon commented Aug 14, 2024•
edited
Loading

Copy link
Copy Markdown
Member

According to our stats the CALL_KW opcode is one of the most common opcodes that prevents projection of tier 2 traces.
Making CALL_KW suitable for tier 2 is infeasible, but we can specialize it in tier 1 such that the specializations can be handled by tier 2.

This PR adds three specializations:

  • CALL_KW_PY for calls to Python functions
  • CALL_KW_BOUND_METHODS for calls to bound methods
  • CALL_KW_NON_PY for calls to everything else.

@bedevere-appbedevere-appBot mentioned this pull request Aug 14, 2024
Closed
3 tasks
@markshannon

markshannon commented Aug 15, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

No impact on performance
Stats show 99.9% specialization with a low (<1%) miss rate.

Fidget-Spinner
Fidget-Spinner reviewed Aug 16, 2024
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Two questions.

Comment threadLib/test/test_dis.py Outdated
Comment threadPython/bytecodes.c
iritkatriel
iritkatriel approved these changes Aug 16, 2024
View reviewed changes
Comment threadInclude/internal/pycore_code.h Outdated
@markshannon@iritkatriel
Update Include/internal/pycore_code.h
8b504ae
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@markshannon
markshannon merged commit c13e7d9 into python:mainAug 16, 2024
@markshannon
markshannon deleted the specialize-call-kw branch August 16, 2024 16:12
jeremyhylton pushed a commit to jeremyhylton/cpython that referenced this pull request Aug 19, 2024
@markshannon@jeremyhylton
pythonGH-118093: SpecializeCALL_KW(pythonGH-123006)
114fa0f
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@markshannon@blhsing
pythonGH-118093: SpecializeCALL_KW(pythonGH-123006)
eea2ba3
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes
@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon@iritkatriel@Fidget-Spinner