Skip to content

[3.13] gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT (GH-122713) - #123184

Merged
markshannon merged 2 commits into
python:3.13from
mpage:gh-122712-on-313
Aug 21, 2024
Merged

[3.13] gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT (GH-122713)#123184
markshannon merged 2 commits into
python:3.13from
mpage:gh-122712-on-313

Conversation

@mpage

@mpagempage commented Aug 20, 2024

Copy link
Copy Markdown
Contributor

Verify the necessary properties of the function's code object in CALL_ALLOC_AND_ENTER_INIT to guard against someone reassigning code.

@mpagempage changed the title gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INITgh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT (GH-122713)Aug 20, 2024
@mpagempage changed the title gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT (GH-122713)[3.13] gh-122712: Guard against __code__ reassignment in CALL_ALLOC_AND_ENTER_INIT (GH-122713)Aug 20, 2024
@mpage

Copy link
Copy Markdown
ContributorAuthor

JIT failures look like qemu issues and are unrelated to this diff:

ERROR:../../plugins/core.c:221:qemu_plugin_vcpu_init_hook: assertion failed: (success)
Bail out! ERROR:../../plugins/core.c:221:qemu_plugin_vcpu_init_hook: assertion failed: (success)
aarch64-binfmt-P: ./include/qemu/rcu.h:101: rcu_read_unlock: Assertion `p_rcu_reader->depth != 0' failed.

@mpage
mpage marked this pull request as ready for review August 20, 2024 22:12
@mpage

Copy link
Copy Markdown
ContributorAuthor

@brandtbucher@markshannon - This is a backport of gh-122713 for 3.13. Happy to continue with this or let you take care of backporting gh-123140 to 3.13.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mpage@markshannon