Skip to content

Fix typos in comments - #123201

Merged
AlexWaygood merged 2 commits into
python:mainfrom
Wulian233:typo
Aug 21, 2024
Merged

Fix typos in comments#123201
AlexWaygood merged 2 commits into
python:mainfrom
Wulian233:typo

Conversation

@Wulian233

@Wulian233Wulian233 commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

skip news and issues

AlexWaygood
AlexWaygood requested changes Aug 21, 2024
View reviewed changes
Comment threadLib/tkinter/__init__.py Outdated
Comment threadLib/tkinter/__init__.py Outdated
Comment threadModules/_ctypes/_ctypes_test.c Outdated
Comment threadLib/test/test_weakref.py
@bedevere-app

bedevere-appBot commented Aug 21, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Wulian233

Wulian233 commented Aug 21, 2024

Copy link
Copy Markdown
ContributorAuthor

please review again

AlexWaygood
AlexWaygood approved these changes Aug 21, 2024
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AlexWaygood
AlexWaygood enabled auto-merge (squash) August 21, 2024 12:22
@AlexWaygood
AlexWaygood merged commit 94036e4 into python:mainAug 21, 2024
@Wulian233
Wulian233 deleted the typo branch August 21, 2024 12:57
@picnixz

picnixz commented Aug 21, 2024

Copy link
Copy Markdown
Member

@AlexWaygood Do you want to backport it?

@AlexWaygood

AlexWaygood commented Aug 21, 2024

Copy link
Copy Markdown
Member

@AlexWaygood Do you want to backport it?

I don't think any of these changes are user-facing (except for maybe the tkinter docstring) so I'm not sure it's worth it, especially during a release-candidate period when we're meant to be aiming for stability above all else

@picnixz

picnixz commented Aug 21, 2024

Copy link
Copy Markdown
Member

Agreed. Let's keep it as a feature for 3.14.

blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@Wulian233@blhsing
Fix typos in comments (python#123201)
4fcdde2
@Wulian233Wulian233 mentioned this pull request Aug 29, 2024
Merged
@Wulian233Wulian233 mentioned this pull request Sep 2, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes
@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstraJelleZijlstra is a code owner
@gaogaotiantiangaogaotiantianAwaiting requested review from gaogaotiantiangaogaotiantian is a code owner
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner
@gvanrossumgvanrossumAwaiting requested review from gvanrossum
@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner
@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

No one assigned

Labels

skip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Wulian233@picnixz@AlexWaygood