Skip to content

gh-123243: Fix reference leak in _decimal - #123244

Merged
kumaraditya303 merged 8 commits into
python:mainfrom
neonene:decimal-leak
Aug 24, 2024
Merged

gh-123243: Fix reference leak in _decimal#123244
kumaraditya303 merged 8 commits into
python:mainfrom
neonene:decimal-leak

Conversation

@neonene

@neoneneneonene commented Aug 22, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor
>python -X showrefcount -c "import _decimal"
[7117 refs, 4232 blocks] # Before
[0 refs, 0 blocks] # After

cc @kumaraditya303@erlend-aasland

@bedevere-appbedevere-appBot mentioned this pull request Aug 22, 2024
Closed
@rhettinger
rhettinger removed their request for review August 23, 2024 00:12
erlend-aasland
erlend-aasland reviewed Aug 23, 2024
View reviewed changes
Comment threadModules/_decimal/_decimal.c Outdated
erlend-aasland
erlend-aasland reviewed Aug 23, 2024
View reviewed changes
Comment threadModules/_decimal/_decimal.c Outdated
@kumaraditya303kumaraditya303 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Aug 23, 2024
@bedevere-bot

bedevere-bot commented Aug 23, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 33af89b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Aug 23, 2024
@kumaraditya303
kumaraditya303 merged commit 5ff638f into python:mainAug 24, 2024
@kumaraditya303kumaraditya303 added the needs backport to 3.13 bugs and security fixes label Aug 24, 2024
@miss-islington-app

miss-islington-appBot commented Aug 24, 2024

Copy link
Copy Markdown

Thanks @neonene for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 24, 2024
@neonene@miss-islington
pythongh-123243: Fix reference leak in_decimal(pythonGH-123244)
ddc48bf
(cherry picked from commit 5ff638f)
Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Aug 24, 2024

Copy link
Copy Markdown

GH-123280 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Aug 24, 2024
kumaraditya303 pushed a commit that referenced this pull request Aug 24, 2024
@miss-islington@neonene
[3.13]gh-123243: Fix reference leak in_decimal(GH-123244) (#123280)
a65fe07
gh-123243: Fix reference leak in `_decimal` (GH-123244)
(cherry picked from commit 5ff638f)
Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
@neonene
neonene deleted the decimal-leak branch August 24, 2024 08:25
@ZeroIntensityZeroIntensity mentioned this pull request Sep 4, 2024
Closed
@ZeroIntensity

ZeroIntensity commented Sep 4, 2024

Copy link
Copy Markdown
Member

This has caused a regression: #123657

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland left review comments
@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@neonene@bedevere-bot@ZeroIntensity@erlend-aasland@kumaraditya303