Skip to content

gh-123424: add ZipInfo._for_archive to set suitable default properties - #123429

Merged
jaraco merged 8 commits into
python:mainfrom
picnixz:feat/zipfile-for-name-123424
Dec 29, 2024
Merged

gh-123424: add ZipInfo._for_archive to set suitable default properties#123429
jaraco merged 8 commits into
python:mainfrom
picnixz:feat/zipfile-for-name-123424

Conversation

@picnixz

@picnixzpicnixz commented Aug 28, 2024•
edited by jaraco
Loading

Copy link
Copy Markdown
Member

@picnixz
picnixz requested a review from jaraco as a code ownerAugust 28, 2024 14:20
@bedevere-appbedevere-appBot mentioned this pull request Aug 28, 2024
Closed
jaraco
jaraco reviewed Aug 28, 2024
View reviewed changes

@jaracojaraco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I have some thoughts about alternative approaches. Interested to hear what you think.

Comment threadLib/zipfile/__init__.py Outdated
Comment threadLib/zipfile/__init__.py Outdated
@Wulian233

Wulian233 commented Nov 2, 2024

Copy link
Copy Markdown
Contributor

Is there anything else that needs to be changed/discussion in this PR? I had another PR #124435 (which has been completed) that conflicted with these changes.

After merge, I can continue handle my PR :)

#124435 (review)

@picnixz

picnixz commented Nov 2, 2024

Copy link
Copy Markdown
MemberAuthor

I don't have time for this one sorry. I didn't implement the suggestion with composition due to other issues that seemed more pressing (and I don't plan to come back here before I'm done with providing HACL* HMAC, at least).

@jaracojaraco self-assigned this Dec 29, 2024
@jaraco
jaracoforce-pushed the feat/zipfile-for-name-123424 branch from f578f66 to 44e7b75CompareDecember 29, 2024 18:07
@jaracojaraco changed the title gh-123424: add ZipInfo.for_name to construct a ZipInfo for a file in an archivegh-123424: add ZipInfo._for_archive to set suitable default propertiesDec 29, 2024
@jaraco
jaraco enabled auto-merge (squash) December 29, 2024 18:23
@jaraco
jaraco merged commit 7e819ce into python:mainDec 29, 2024
@picnixz

picnixz commented Dec 31, 2024

Copy link
Copy Markdown
MemberAuthor

Thank you very much for taking over this @jaraco. Sorry for not honoring my initial commitment but I couldn't find the time/motivation to work on this one :(

@picnixz
picnixz deleted the feat/zipfile-for-name-123424 branch December 31, 2024 17:27
@jaraco

jaraco commented Dec 31, 2024

Copy link
Copy Markdown
Member

Thank you very much for taking over this @jaraco. Sorry for not honoring my initial commitment but I couldn't find the time/motivation to work on this one :(

No need to apologize. Thanks for the original work and being proactive about your availability.

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@picnixz@jaraco@srinivasreddy
pythongh-123424: addZipInfo._for_archiveto set suitable default p…
7c0567d
…roperties (python#123429)
---------
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@jaracojaraco mentioned this pull request May 12, 2025
Closed
jaraco added a commit to jaraco/zipp that referenced this pull request May 12, 2025
@picnixz@jaraco
Cherry-pick changes frompython/cpython#123429.
bc37b6e
python/cpython#123424: add `ZipInfo._for_archive` to set suitable default properties
---------
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco added a commit to jaraco/zipp that referenced this pull request May 12, 2025
@picnixz@jaraco
Cherry-pick changes frompython/cpython#123429.
511a7a3
python/cpython#123424: add `ZipInfo._for_archive` to set suitable default properties
---------
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@jaracojaraco mentioned this pull request May 26, 2025
Merged
jaraco added a commit to jaraco/zipp that referenced this pull request May 26, 2025
@jaraco
Merge pull request#142from jaraco/backport-gh-123429
73cdd55
Backport python/cpython#123429
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaracojaracojaraco approved these changes

Assignees

@jaracojaraco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extract ZipInfo for archive functionality

3 participants

@picnixz@Wulian233@jaraco